karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guillaume Nodet (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-3103) config:edit does not correctly handle configuration visibility for --factory calls.
Date Wed, 17 Sep 2014 20:37:34 GMT

    [ https://issues.apache.org/jira/browse/KARAF-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137943#comment-14137943

Guillaume Nodet commented on KARAF-3103:

The two issues are similar but unrelated.
This issue is solved by the provided patch.
The visibility of non factory configurations is a regression introduced by the fix for KARAF-3204.
We need to verify all calls to {{ConfigurationAdmin#getConfiguration(String pid)}} and pass
{{null}} as the second parameter when the purpose is to modify a configuration supposed to
be used by a different bundle.

> config:edit does not correctly handle configuration visibility for --factory calls.
> -----------------------------------------------------------------------------------
>                 Key: KARAF-3103
>                 URL: https://issues.apache.org/jira/browse/KARAF-3103
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-config
>    Affects Versions: 4.0.0, 3.0.2
>            Reporter: Richard Kaufhold
>         Attachments: patch-ConfigRepositoryImpl-visibility.txt
>   Original Estimate: 10m
>  Remaining Estimate: 10m
> The ConfigRepositoryImpl does not specify the visibility for created factory configurations.

> I have tested it using my own ManagedServiceFactory:
> Inside of the karaf shell I executed:
> karaf@root()> config:edit --factory de.ansii.example.hellofactory
> karaf@root()> config:property-append prop1 value1
> karaf@root()> config:update
> The response was:
> 2014-07-07 15:18:45,038 | ERROR | 04-24cc6aa84094) | configadmin                    
 | 5 - org.apache.felix.configadmin - 1.6.0 | Cannot use configuration de.ansii.example.hellofactory.5b076892-5207-4913-a704-24cc6aa84094
for [org.osgi.service.cm.ManagedServiceFactory, id=90, bundle=65/mvn:de.ansii.example/hellofactory]:
No visibility to configuration bound to mvn:org.apache.karaf.config/org.apache.karaf.config.core/4.0.0-SNAPSHOT
> In line 91 of /org.apache.karaf.config.core/src/main/java/org/apache/karaf/config/core/impl/ConfigRepositoryImpl.java
the visibility is not specified which leads to the problem that the factory configuration
created by config:edit --factory is not usable by factory implementations. (null is a sensible
default, as in line 44)

This message was sent by Atlassian JIRA

View raw message