karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Baptiste Onofré (JIRA) <j...@apache.org>
Subject [jira] [Commented] (KARAF-3055) tabbing in subshell displays more than commands of the current subshell
Date Fri, 19 Sep 2014 08:16:35 GMT

    [ https://issues.apache.org/jira/browse/KARAF-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140167#comment-14140167
] 

Jean-Baptiste Onofré commented on KARAF-3055:
---------------------------------------------

Fixed on karaf-3.0.x: https://git-wip-us.apache.org/repos/asf?p=karaf.git;a=commitdiff;h=1852de625367399d87a8d057e381a4e2c9320069

> tabbing in subshell displays more than commands of the current subshell
> -----------------------------------------------------------------------
>
>                 Key: KARAF-3055
>                 URL: https://issues.apache.org/jira/browse/KARAF-3055
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-shell
>    Affects Versions: 3.0.1
>            Reporter: Rebecca Chan
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>             Fix For: 4.0.0, 3.0.2
>
>
> According to subshell release note, if the complete mode is set to either 'FIRST' or
'SUBSHELL' and you type the TAB key when you are in a subshell, the completion will display
only the commands of the current subshell.  
> I have two subshells, auth and auth-ldap.   Each has different commands.
> auth:show
> auth-ldap:update
> auth-ldap:delete
> The complete mode is set to 'FIRST'.  
> When I am in subshell 'auth' and press tab, I expect to see only the 'show' command.
  However, 'show', 'delete' and 'update' are displayed in the 'auth' subshell.
> *CAUSE*
> After looking into the source code of karaf 3.0.1, there is a bug in method 'complete'
in 'org.apache.karaf.shell.console.completer.CommandsCompleter'.  If the key of a completer
starts with the current subshell name, the completer will be added to the matching completer
list.  For my case, the current subshell name 'auth' partially matches the keys, "auth-ldap:update"
and "auth-ldap:delete" , of completers and incorrect commands,"update" and "delete" are displayed
in "auth" subshell.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message