Return-Path: X-Original-To: apmail-karaf-issues-archive@minotaur.apache.org Delivered-To: apmail-karaf-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E389C111F2 for ; Tue, 15 Apr 2014 08:41:38 +0000 (UTC) Received: (qmail 60938 invoked by uid 500); 15 Apr 2014 08:41:38 -0000 Delivered-To: apmail-karaf-issues-archive@karaf.apache.org Received: (qmail 60765 invoked by uid 500); 15 Apr 2014 08:41:33 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 60078 invoked by uid 99); 15 Apr 2014 08:41:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Apr 2014 08:41:17 +0000 Date: Tue, 15 Apr 2014 08:41:17 +0000 (UTC) From: "Freeman Fang (JIRA)" To: issues@karaf.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KARAF-2910) Properties login module seems to leak a PropertiesInstaller reference results in OOM MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KARAF-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969341#comment-13969341 ] Freeman Fang commented on KARAF-2910: ------------------------------------- Hi Gary, Thanks for pointing out this issue and append a patch. We need PropertiesInstaller to monitor the etc/users.properties changes, but we should avoid registering multiple PropertiesInstaller as service. I fixed this and integrate your testcase. Best Regards Freeman > Properties login module seems to leak a PropertiesInstaller reference results in OOM > ------------------------------------------------------------------------------------ > > Key: KARAF-2910 > URL: https://issues.apache.org/jira/browse/KARAF-2910 > Project: Karaf > Issue Type: Bug > Components: karaf-security > Affects Versions: 2.3.2 > Environment: jaas login > Reporter: Gary Tully > Assignee: Freeman Fang > Fix For: 2.4.0, 4.0.0, 3.0.2, 2.3.6 > > Attachments: KARAF-2910-test+patch.txt > > > with the default jaas login config - repeated login attempts lead to OOM. > heap dump shows: > org.apache.karaf.jaas.modules.properties.PropertiesInstaller 86,374 instances > on investigation seems each PropertiesLogin init registers a PropertiesInstaller service that I don't see used. > Unit test and possible fix (though I have no idea what a PropertiesInstaller service should do) attached. -- This message was sent by Atlassian JIRA (v6.2#6252)