karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Bosschaert (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-2567) Add support for JAAS groups - backport to 2.x
Date Wed, 13 Nov 2013 09:01:29 GMT

    [ https://issues.apache.org/jira/browse/KARAF-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821079#comment-13821079
] 

David Bosschaert commented on KARAF-2567:
-----------------------------------------

Thanks for the fix, JB. However I'd like to understand a bit better why this was needed.
I re-ran a full build from scratch before your change and that succeeded fine for me. 

So let's take a look at one of these, line 98 in the PropertiesLoginModule, now contains a
cast to String:
  userInfos = (String) users.get(user);
why is this needed?

users is of type org.apache.felix.utils.properties.Properties. And this Properties type is
declared as:
  public class Properties extends AbstractMap<String, String> {
So by applying the generics rules, get() should already be returning a String. In fact my
editor (Eclipse) automatically removes this new cast as being unneccesary. 
I'm just trying to understand what is causing the failure you were seeing...

> Add support for JAAS groups - backport to 2.x
> ---------------------------------------------
>
>                 Key: KARAF-2567
>                 URL: https://issues.apache.org/jira/browse/KARAF-2567
>             Project: Karaf
>          Issue Type: New Feature
>          Components: karaf-core
>    Affects Versions: 2.3.3
>            Reporter: David Bosschaert
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 2.4.0
>
>
> Backport the work done for KARAF-2434 to 2.x



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message