karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heath Kesler (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KARAF-1748) Karaf startup fails with NullPointerException when logfile can't be written
Date Sun, 16 Sep 2012 18:28:07 GMT

     [ https://issues.apache.org/jira/browse/KARAF-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Heath Kesler updated KARAF-1748:
--------------------------------

    Attachment: karaf-3.0_1748.diff

updated the BootstrapLogManager to throw exception rather then doing a printstacktrace to
give calling classes more control over what gets printed to the console.  The main class will
now only print out the exception message, but the stack trace will still get logged (if it
is an exception that does not involve an issue with instantiating the log file).  

I am looking for feedback on this patch,I am not 100% convinced that I should not be writing
out the stack trace, but I do not know of an issue where it should.  

All tests pass.

Thanks
Heath
                
> Karaf startup fails with NullPointerException when logfile can't be written
> ---------------------------------------------------------------------------
>
>                 Key: KARAF-1748
>                 URL: https://issues.apache.org/jira/browse/KARAF-1748
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-core
>    Affects Versions: 2.2.9, 2.3.0, 3.0.0
>            Reporter: Christoph Läubrich
>            Priority: Minor
>         Attachments: karaf-3.0_1748.diff
>
>
> The karaf startup fails with a NullPointerException when the logifle can't be accessed:
> java.io.FileNotFoundException: /opt/karaf/data/log/karaf.log (Permission denied)
>         at java.io.FileOutputStream.openAppend(Native Method)
>         at java.io.FileOutputStream.<init>(FileOutputStream.java:177)
>         at org.apache.karaf.main.BootstrapLogManager$SimpleFileHandler.open(BootstrapLogManager.java:115)
>         at org.apache.karaf.main.BootstrapLogManager$SimpleFileHandler.<init>(BootstrapLogManager.java:104)
>         at org.apache.karaf.main.BootstrapLogManager.getDefaultHandler(BootstrapLogManager.java:83)
>         at org.apache.karaf.main.Main.launch(Main.java:234)
>         at org.apache.karaf.main.Main.main(Main.java:429)
> Could not create framework: java.lang.NullPointerException
> java.lang.NullPointerException
>         at java.util.logging.Logger.addHandler(Logger.java:1185)
>         at org.apache.karaf.main.Main.launch(Main.java:234)
>         at org.apache.karaf.main.Main.main(Main.java:429)
> This should be changed to: Output a meaningfull message e.g. "Karaf can't startup, make
sure the logifle can be accessed and written by the user starting Karaf",
> OR
> try to allocate a logfile with a different name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message