Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Date: Mon, 23 Jul 2012 07:29:34 +0000 (UTC)
From: "Freeman Fang (JIRA)" <jira@apache.org>
To: issues@karaf.apache.org
Message-ID: <552182631.90162.1343028574922.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1858956510.86667.1342902694660.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (KARAF-1657)
 org.ops4j.pax.url.mvn.proxySupport=false
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/KARAF-1657?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1342=
0484#comment-13420484 ]=20

Freeman Fang commented on KARAF-1657:
-------------------------------------

Hi Andreas,

We currently comment out org.ops4j.pax.url.mvn.proxySupport configuration b=
y default, which means in Karaf we  use default value  of org.ops4j.pax.url=
.mvn.proxySupport from PAX-URL out-of-box so far, which is "true"(according=
 to PAX-URL docs). By my test, the default org.ops4j.pax.url.mvn.proxySuppo=
rt=3Dtrue in  PAX-URL  means, it will just try to use(but not only use prox=
y) maven proxy support if the proxy configuration is in maven settings.xml =
and the proxy is available. That said,  PAX-URL  can still use normal maven=
 way even the proxy isn't available or there's no proxy configuration in ma=
ven settings.xml with default org.ops4j.pax.url.mvn.proxySupport=3Dtrue.=20

So the current configuration (including the comments)
#
# Uncomment if you are behind a web proxy. PAX URL will use the proxy setti=
ngs
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=3Dtrue

isn't correct, as it's actually same behavior with or without
org.ops4j.pax.url.mvn.proxySupport=3Dtrue

So I think we need change it to
#
# Uncomment if you don't wanna use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=3Dfalse

And I don't see the side effect of this change, as all what we change is st=
ill in the comment.

I might miss something, so if other guys have different input, please let m=
e know.

Regards
Freeman
               =20
> org.ops4j.pax.url.mvn.proxySupport=3Dfalse
> ----------------------------------------
>
>                 Key: KARAF-1657
>                 URL: https://issues.apache.org/jira/browse/KARAF-1657
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Michael Prie=C3=9F
>            Assignee: Freeman Fang
>
> {code}
> #
> # Uncomment if you are behind a web proxy. PAX URL will use the proxy set=
tings
> # from the Maven conf/settings.xml file
> #
> # org.ops4j.pax.url.mvn.proxySupport=3Dtrue
> {code}
> http://team.ops4j.org/wiki/display/paxurl/Mvn+Protocol=20
> The configuration of pax url is per default true. If you read this commen=
t inside org.ops4j.pax.url.mvn.cfg you expect that the default configuratio=
n must be false.=20
> I prefer to set the configuration per default to false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira