karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schneider (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (KARAF-1627) Remove sshd command and instead make sshd react directly to config changes
Date Thu, 05 Jul 2012 12:12:34 GMT

    [ https://issues.apache.org/jira/browse/KARAF-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407029#comment-13407029
] 

Christian Schneider edited comment on KARAF-1627 at 7/5/12 12:11 PM:
---------------------------------------------------------------------

Thx for the information. I was not aware that these system prorperties are controlled by the
start script. Looking into the karaf.bat script I found that the ssh server is started for
all modes except for client. On the other hand client.bat does not seem to call karaf.bat.
So I am not sure what the use case for calling karaf client is. In case this is only old code
we could remove the karaf.startRemoteShell properties and control the sshd behaviour like
I proposed. Of course switching off the ssh server using the config will make the client not
work anymore but I guess that is ok for people.

                
      was (Author: chris@die-schneider.net):
    Thx for the information. I was not aware that these system prorperties are controlled
by the start script. Looking into the karaf.bat script I found that the ssh server is started
for all modes except for client. On the other hand client.bat does not seem to call karaf.bat.
So I am not sure what the use case for calling karaf client is. In case this is only old code
we could remove the karaf.startRemoteShell properties and control the sshd behaviour like
I proposed.

                  
> Remove sshd command and instead make sshd react directly to config changes
> --------------------------------------------------------------------------
>
>                 Key: KARAF-1627
>                 URL: https://issues.apache.org/jira/browse/KARAF-1627
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-shell
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
>             Fix For: 3.0.0
>
>
> Currently the start of sshd is controlled using
> "system.properties" there we have the attribute
> "karaf.startRemoteShell" which can be true or false. The problem with this is that changes
do not make sshd react directly. You have to restart karaf.
> So we have the sshd command which can also start the ssh server. The problem with the
command is that it can only start the server but not stop it. It also start a new server with
each call.
> I propose we remove the sshd command and instead move the attribute to control the start
into org.apache.karaf.shell.cfg. This is already read using config admin and changes are reflected
in real time. 
> I propose the attribute sshdStart=true|false with default to true.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message