karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Freeman Fang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-1515) features-generate-descriptor does not set the version in generated features
Date Mon, 04 Jun 2012 00:26:22 GMT

    [ https://issues.apache.org/jira/browse/KARAF-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288297#comment-13288297
] 

Freeman Fang commented on KARAF-1515:
-------------------------------------

Hi Benjamin,

Just found the jira patch attachment doesn't work properly, so even you select the "Grant
Apache License" radio button, still can't see the Apache feather icon with the attachment,
this is the Apache Jira issue.

Back to your patch, just one thing, webconsole/features/src/main/java/org/apache/karaf/webconsole/features/ExtendedFeature.java
implements Feature, but you didn't add new hasVersion() method for that class which cause
compilation error. So next time when you attach patch, you need ensure it doesn't break any
compilation and tests.

I just add that minor change and will apply your patch soon.
Thanks for the patch.

Freeman
                
> features-generate-descriptor does not set the version in generated features
> ---------------------------------------------------------------------------
>
>                 Key: KARAF-1515
>                 URL: https://issues.apache.org/jira/browse/KARAF-1515
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-tooling
>    Affects Versions: 3.0.0
>            Reporter: Benjamin Reed
>            Assignee: Freeman Fang
>             Fix For: 3.0.0
>
>         Attachments: KARAF-1515.patch
>
>
> When using features-generate-descriptor, the generated features.xml does not set a version.
 It appears to be because the Feature model checks for null in getVersion(), so it's always
returning either the set version string, or the string "0.0.0".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message