Return-Path: X-Original-To: apmail-karaf-issues-archive@minotaur.apache.org Delivered-To: apmail-karaf-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 66154CA9D for ; Thu, 3 May 2012 09:03:14 +0000 (UTC) Received: (qmail 23700 invoked by uid 500); 3 May 2012 09:03:14 -0000 Delivered-To: apmail-karaf-issues-archive@karaf.apache.org Received: (qmail 23675 invoked by uid 500); 3 May 2012 09:03:14 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 23667 invoked by uid 99); 3 May 2012 09:03:14 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 May 2012 09:03:14 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 May 2012 09:03:13 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E747842DAE0 for ; Thu, 3 May 2012 09:02:52 +0000 (UTC) Date: Thu, 3 May 2012 09:02:52 +0000 (UTC) From: "Tuomas Kiviaho (JIRA)" To: issues@karaf.apache.org Message-ID: <2081144528.21024.1336035772948.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1558027430.21012.1336035541813.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Issue Comment Edited] (KARAF-1432) karaf:features-validate-descriptor parses system packages incorrectly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/KARAF-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267315#comment-13267315 ] Tuomas Kiviaho edited comment on KARAF-1432 at 5/3/12 9:02 AM: --------------------------------------------------------------- {code} #P karaf-maven-plugin Index: src/main/java/org/apache/karaf/tooling/features/ValidateDescriptorMojo.java =================================================================== --- src/main/java/org/apache/karaf/tooling/features/ValidateDescriptorMojo.java (revision 1300512) +++ src/main/java/org/apache/karaf/tooling/features/ValidateDescriptorMojo.java (working copy) @@ -54,14 +66,12 @@ import org.apache.maven.shared.dependency.tree.DependencyTreeBuilder; import org.apache.maven.shared.dependency.tree.traversal.DependencyNodeVisitor; +import aQute.libg.header.OSGiHeader; /** * Validates a features XML file * - * @version $Revision:$ + * @version $Revision$ * @goal features-validate-descriptor * @execute phase="process-resources" * @requiresDependencyResolution runtime @@ -343,12 +353,7 @@ } String packages = (String) properties.get(jreVersion); - for (String pkg : packages.split(";")) { - systemExports .add(pkg.trim()); - } - for (String pkg : packages.split(",")) { - systemExports .add(pkg.trim()); - } + systemExports.addAll(OSGiHeader.parseHeader(packages).keySet()); } {code} was (Author: tuomas_kiviaho): #P karaf-maven-plugin Index: src/main/java/org/apache/karaf/tooling/features/ValidateDescriptorMojo.java =================================================================== --- src/main/java/org/apache/karaf/tooling/features/ValidateDescriptorMojo.java (revision 1300512) +++ src/main/java/org/apache/karaf/tooling/features/ValidateDescriptorMojo.java (working copy) @@ -54,14 +66,12 @@ import org.apache.maven.shared.dependency.tree.DependencyTreeBuilder; import org.apache.maven.shared.dependency.tree.traversal.DependencyNodeVisitor; +import aQute.libg.header.OSGiHeader; /** * Validates a features XML file * - * @version $Revision:$ + * @version $Revision$ * @goal features-validate-descriptor * @execute phase="process-resources" * @requiresDependencyResolution runtime @@ -343,12 +353,7 @@ } String packages = (String) properties.get(jreVersion); - for (String pkg : packages.split(";")) { - systemExports .add(pkg.trim()); - } - for (String pkg : packages.split(",")) { - systemExports .add(pkg.trim()); - } + systemExports.addAll(OSGiHeader.parseHeader(packages).keySet()); } > karaf:features-validate-descriptor parses system packages incorrectly > --------------------------------------------------------------------- > > Key: KARAF-1432 > URL: https://issues.apache.org/jira/browse/KARAF-1432 > Project: Karaf > Issue Type: Bug > Components: karaf-tooling > Affects Versions: 3.0.0 > Reporter: Tuomas Kiviaho > > Config.properties containing jre system packages is parsed without taking care of osgi header syntax. javax.transaction is not parsed correctly for jre 1.6 and neither are entries that are defived from felix (I guess that the syntax should be still the same). > By using BND's OSGiHeader.parseHeader this can be easily fixed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira