Return-Path: X-Original-To: apmail-karaf-issues-archive@minotaur.apache.org Delivered-To: apmail-karaf-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A07CCDA1 for ; Tue, 8 May 2012 20:32:10 +0000 (UTC) Received: (qmail 92958 invoked by uid 500); 8 May 2012 20:32:10 -0000 Delivered-To: apmail-karaf-issues-archive@karaf.apache.org Received: (qmail 92910 invoked by uid 500); 8 May 2012 20:32:10 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 92894 invoked by uid 99); 8 May 2012 20:32:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 May 2012 20:32:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 May 2012 20:32:08 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E93BE43A549 for ; Tue, 8 May 2012 20:31:48 +0000 (UTC) Date: Tue, 8 May 2012 20:31:48 +0000 (UTC) From: "Christian Schneider (JIRA)" To: issues@karaf.apache.org Message-ID: <1277403339.40922.1336509108956.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1242148479.4479.1309970596773.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (KARAF-713) Refactor karaf main MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved KARAF-713. --------------------------------------- Resolution: Fixed Through my other changes the class is now down to about 400 lines and much more readable > Refactor karaf main > ------------------- > > Key: KARAF-713 > URL: https://issues.apache.org/jira/browse/KARAF-713 > Project: Karaf > Issue Type: Improvement > Components: karaf-core > Affects Versions: 2.2.2 > Reporter: Christian Schneider > Assignee: Christian Schneider > Fix For: 3.0.0 > > > The karaf main project is currently not so well structured. > The class Main has too many responsibilities and is too big (almost 1500 lines). > The lock classes are in the main package. They should be moved to a separate package. > Proposal: > create package lock and put everything about locking there. The case without locking should be handled as another lock implementation > Split the Main class into setup of the framework and LifeCycleManager that handles the lock / start and stopping -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira