Return-Path: X-Original-To: apmail-karaf-issues-archive@minotaur.apache.org Delivered-To: apmail-karaf-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BEFD19D86 for ; Fri, 24 Feb 2012 06:39:13 +0000 (UTC) Received: (qmail 3586 invoked by uid 500); 24 Feb 2012 06:39:13 -0000 Delivered-To: apmail-karaf-issues-archive@karaf.apache.org Received: (qmail 3537 invoked by uid 500); 24 Feb 2012 06:39:13 -0000 Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list issues@karaf.apache.org Received: (qmail 3450 invoked by uid 99); 24 Feb 2012 06:39:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2012 06:39:13 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2012 06:39:10 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D77C4337BE6 for ; Fri, 24 Feb 2012 06:38:48 +0000 (UTC) Date: Fri, 24 Feb 2012 06:38:48 +0000 (UTC) From: "Lukas Roedl (Commented) (JIRA)" To: issues@karaf.apache.org Message-ID: <1234396678.14105.1330065528883.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <892214505.11922.1330033668721.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (KARAF-1223) Support mvn:* urls in karaf-maven-plugin:features-create-kar MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/KARAF-1223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215435#comment-13215435 ] Lukas Roedl commented on KARAF-1223: ------------------------------------ Maybe let me just explain my setup: I've a multi-module project - 2 of this modules consist of only one features file (one of them describes the "core" features and the other one the "examples" features). A third module is the "framework" (with Karaf and dependencies to the other modules, the "deploy" folder should contain the two kar files in the end). The Problem: What I want to do is to generate 2 separate kar files (one for "core and the other one for the "examples"). If I do this (in the pom of the "framework") via the karaf-maven-plugin with 2 executions configured and relative path references to the two features files I get the two desired kar files. When I now start Karaf both kar files are deployed to the local Karaf repo but because the both kar files contain the features descriptor with the same groupId/artifactId the "last" kar file deployed overwrites the feature descriptor of the previous ones. The problem is that the plugin takes the groupId/artifactId of the pom for the groupId/artifactId of the features descriptor. I already discussed this issue some days ago http://irclogs.dankulp.com/logs/irclogger_log/karaf?date=2012-02-21,Tue#l101 My solution now was to allow the karaf-maven-plugin to accept also mvn:* urls for the featuresFile property and resolve the "real" groupId/artifactId in such cases. But maybe there is a better/cleaner solution for my problem? What do you suggest? > Support mvn:* urls in karaf-maven-plugin:features-create-kar > ------------------------------------------------------------ > > Key: KARAF-1223 > URL: https://issues.apache.org/jira/browse/KARAF-1223 > Project: Karaf > Issue Type: Improvement > Components: karaf-tooling > Affects Versions: 3.0.0 > Reporter: Lukas Roedl > Fix For: 3.0.0 > > Attachments: CreateKarMojo.java.patch > > > The features-create-kar goal of the karaf-maven-plugin plugin currently only supports references to local feature files. The featuresFile tag should also support mvn:* urls. > This may also avoid the following problem if the features file is added with the correct groupId/artifactId. > In a single pom the karaf-maven-plugin with goal features-create-kar is executed twice to generate two separate kar files from two independent features.xml files. > The resulting kar files are deployed to the "deploy" folder and at Karaf's startup it seems that only one of them is loaded. > The plugin adds the feature files with the same groupId/artifactId to the kar files and while deploying they overwrite each other. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira