Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Date: Wed, 22 Feb 2012 14:49:48 +0000 (UTC)
From: "Claus Ibsen (Commented) (JIRA)" <jira@apache.org>
To: issues@karaf.apache.org
Message-ID: 
 <1182845665.4378.1329922188763.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <985820922.4371.1329922068623.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (KARAF-1218) Only use 1 thread for file
 installer watcher
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/KARAF-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213664#comment-13213664 ] 

Claus Ibsen commented on KARAF-1218:
------------------------------------

Also there is 2 other main threads. It would be nice to give this threads a better name, than just Thread-2 and Thread-3.
{code}
"Thread-3" daemon prio=5 tid=7fa0cb206800 nid=0x1100e0000 runnable [1100df000]
   java.lang.Thread.State: RUNNABLE
	at java.net.PlainSocketImpl.socketAccept(Native Method)
	at java.net.PlainSocketImpl.accept(PlainSocketImpl.java:408)
	- locked <7e008c160> (a java.net.SocksSocketImpl)
	at java.net.ServerSocket.implAccept(ServerSocket.java:462)
	at java.net.ServerSocket.accept(ServerSocket.java:430)
	at org.apache.karaf.main.Main$ShutdownSocketThread.run(Main.java:1394)

"Thread-2" prio=5 tid=7fa0cc2c7800 nid=0x10ffdd000 waiting on condition [10ffdc000]
   java.lang.Thread.State: TIMED_WAITING (sleeping)
	at java.lang.Thread.sleep(Native Method)
	at org.apache.karaf.main.Main.doLock(Main.java:1302)
	at org.apache.karaf.main.Main.lock(Main.java:1277)
	at org.apache.karaf.main.Main$1.run(Main.java:277)
{code}
                
> Only use 1 thread for file installer watcher
> --------------------------------------------
>
>                 Key: KARAF-1218
>                 URL: https://issues.apache.org/jira/browse/KARAF-1218
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.2.5
>            Reporter: Claus Ibsen
>            Priority: Minor
>
> When running Apache Karaf 2.2.5 then we want to run it with as low overhead as possible. Out of the box it has around 30+ live threads running, which is a fair bit.
> We should try to consolidate if applicable. For example there is 2 separate threads for picking up file installer. This can be implemented as a single thread instead.
> {code}
> "fileinstall-/opt/apache-karaf-2.2.5/deploy" daemon prio=5 tid=7fa0cc26d800 nid=0x1104ec000 in Object.wait() [1104eb000]
>    java.lang.Thread.State: TIMED_WAITING (on object monitor)
> 	at java.lang.Object.wait(Native Method)
> 	- waiting on <7e0690610> (a org.apache.felix.fileinstall.internal.DirectoryWatcher)
> 	at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:268)
> 	- locked <7e0690610> (a org.apache.felix.fileinstall.internal.DirectoryWatcher)
> "fileinstall-/opt/apache-karaf-2.2.5/etc" daemon prio=5 tid=7fa0cc26a800 nid=0x1103e9000 in Object.wait() [1103e8000]
>    java.lang.Thread.State: TIMED_WAITING (on object monitor)
> 	at java.lang.Object.wait(Native Method)
> 	- waiting on <7e068e778> (a org.apache.felix.fileinstall.internal.DirectoryWatcher)
> 	at org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:268)
> 	- locked <7e068e778> (a org.apache.felix.fileinstall.internal.DirectoryWatcher)
> {code}
> Those 2 thread should be a single thread, that just watches the 2 directories.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira