karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Baptiste Onofré (Commented) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (KARAF-1199) dev:watch command issues "[WATCH]" announcements only to the issuing shell
Date Sun, 12 Feb 2012 05:46:59 GMT

    [ https://issues.apache.org/jira/browse/KARAF-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206353#comment-13206353
] 

Jean-Baptiste Onofré commented on KARAF-1199:
---------------------------------------------

It makes sense.

Generally speaking, all commands should use a logger for the log, and JLine Ansi for console
output.

In the case of the BundleWatcher, it should use only log, and the watch command should relay
it in the console.
                
> dev:watch command issues "[WATCH]" announcements only to the issuing shell
> --------------------------------------------------------------------------
>
>                 Key: KARAF-1199
>                 URL: https://issues.apache.org/jira/browse/KARAF-1199
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-shell
>    Affects Versions: 2.2.4
>            Reporter: Chris Dolan
>            Priority: Trivial
>             Fix For: 2.2.6, 3.0.0
>
>
> If I issue a "dev:watch *" command and later update one of my snapshot bundles, the announcement
of that change is emitted in the context of the shell that issued the command. That is, if
I issue it in the Gogo ssh shell, then the "[WATCH] ..." announcement goes to that shell.
If I trigger the Watch service programmatically, then the announcement goes to the system
console.
> Instead, I think the announcement should go to the log subsystem. The root cause is that
org.apache.karaf.shell.dev.BundleWatcher uses System.out.println() to emit this message, which
is routed by Gogo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message