karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schneider (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-713) Refactor karaf main
Date Thu, 10 Nov 2011 14:21:51 GMT

    [ https://issues.apache.org/jira/browse/KARAF-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147699#comment-13147699
] 

Christian Schneider commented on KARAF-713:
-------------------------------------------

Hi Guillaume,
sorry that I broke existing functionality. I will try to commit a simpler change soon.
As far as I know the test did not show the break in functionality. Do you think we could describe
the expected behaviour somehow? 
                
> Refactor karaf main
> -------------------
>
>                 Key: KARAF-713
>                 URL: https://issues.apache.org/jira/browse/KARAF-713
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf-core
>    Affects Versions: 2.2.2, 3.0.0
>            Reporter: Christian Schneider
>            Assignee: Guillaume Nodet
>             Fix For: 3.0.0
>
>
> The karaf main project is currently not so well structured.
> The class Main has too many responsibilities and is too big (almost 1500 lines).
> The lock classes are in the main package. They should be moved to a separate package.
> Proposal:
> create package lock and put everything about locking there. The case without locking
should be handled as another lock implementation
> Split the Main class into setup of the framework and LifeCycleManager that handles the
lock / start and stopping

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message