karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Glen Mazza (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KARAF-762) dev:watch should support multiple bundle IDs
Date Sun, 31 Jul 2011 01:20:09 GMT

    [ https://issues.apache.org/jira/browse/KARAF-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13073274#comment-13073274
] 

Glen Mazza commented on KARAF-762:
----------------------------------

I'm not sure dev:watch takes bundle IDs -- it just seems to treat it as a URL, even if it
doesn't make sense.

karaf@root> dev:watch
No watched urls
karaf@root> dev:watch 23
Adding watched urls
Watched urls:
23
karaf@root> dev:watch 23-34
Adding watched urls
Watched urls:
23
23-34
karaf@root> dev:watch 2314
Adding watched urls
Watched urls:
23
23-34
2314
karaf@root> dev:watch
Watched urls:
23
23-34
2314

But the --help information for dev:watch still needs some elaboration IMO.  It currently says:

The watch command can be used to help at developement time. It allows you to configure a set
of URLs that will be monitored. All bundles location matching the given URL will be automatically
updated. This avoids the need for manually updating the bundles or even copying the bundle
to the system folder if needed. Note that only maven based urls and maven snapshots will actually
be updated automatically, so if you run
> dev:watch *
It will actually monitor all bundles that have a location matching mvn:* that have '-SNAPSHOT'
in their url.

Problems:

1.) It doesn't tell us what "monitoring" or "watching" really *means* -- what does watching
a bundle URL mean?  I think it means when the bundle in the Maven repo has been updated that
it will automatically refresh in Karaf as well.  

2.) The example I think is bad, because it will monitor bundles that also *don't* have the
"-SNAPSHOT" in their URL.  (Actually dev:watch * means watch everything?  What is being watched
in that case?  How does it watch every Maven URL -- how does it know what the full list of
Maven URLs are?  Confused.)

3.) The text says "even copying the bundle to the system folder if needed" is no longer necessary.
 I'm not sure why it wouldn't be--does this mean Karaf will automatically copy over the bundle
from the Maven repo to the system folder (physically replace it), or just ignore it and instead
just reference what's in the Maven repo, or?

4.) Some grammatical typos.

I've attached a patch that I believe fixes (1), (2), and (4) -- (3) I'm leaving vague because
I don't know the answer to that.

> dev:watch should support multiple bundle IDs
> --------------------------------------------
>
>                 Key: KARAF-762
>                 URL: https://issues.apache.org/jira/browse/KARAF-762
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf-shell
>    Affects Versions: 2.2.2, 3.0.0
>            Reporter: Achim Nierbeck
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>             Fix For: 2.2.3, 3.0.0
>
>         Attachments: watchTxt.patch
>
>
> if you want to watch multiple bundle you have to re-issue the dev:watch command for every
bundle to be watched. 
> if dev:watch would accept a list of bundle Ids this would help.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message