karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Pieber (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (KARAF-423) KarafJaasPasswordAuthenticator should log reason for authentication failure.
Date Fri, 28 Jan 2011 19:52:44 GMT

     [ https://issues.apache.org/jira/browse/KARAF-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andreas Pieber resolved KARAF-423.
----------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.1.4)

Pushed in revision 1064836

I've modified your patch in the following points:

1) we typical use commons logging instead of slf4j directly
2) + e would add the class ID ; I've changed it to e.getMessage(), e); to include the entire
exception in the log and not only the message

> KarafJaasPasswordAuthenticator should log reason for authentication failure.
> ----------------------------------------------------------------------------
>
>                 Key: KARAF-423
>                 URL: https://issues.apache.org/jira/browse/KARAF-423
>             Project: Karaf
>          Issue Type: Improvement
>          Components: runtime
>    Affects Versions: 2.2.0
>         Environment: Karaf trunk 
>            Reporter: Torsten Mielke
>            Assignee: Andreas Pieber
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: Kara-423f.patch
>
>
> In method KarafJaasPasswordAuthenticator.authenticate() we catch any exceptions at the
end and only return false in the event of an exception
> } catch (Exception e) {
>   return false;
> }
> without logging anything about the reason for the exception, e.g. in case of a FailedLoginException.

> I propose to add some logging in the exception handling. Perhaps at INFO level so that
it gets written to the log file by default.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message