karaf-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andreas Pieber (JIRA)" <j...@apache.org>
Subject [jira] Commented: (KARAF-244) features-maven-plugin does not work with maven 3
Date Thu, 09 Dec 2010 21:09:02 GMT

    [ https://issues.apache.org/jira/browse/KARAF-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969948#action_12969948
] 

Andreas Pieber commented on KARAF-244:
--------------------------------------

Ok... I'm comming closer... the problem is burried in org.apache.karaf.tooling.features.MojoSupport

This method:

{code}
    protected String getLocalRepoUrl() {
         if (System.getProperty("os.name").startsWith("Windows")) {
             String baseDir = localRepo.getBasedir().replace('\\', '/').replaceAll(" ", "%20");
             return localRepo.getProtocol() + ":///" + baseDir;
         } else {
                 return localRepo.getUrl();
         }
    }
{code}

; or to be more specifc this part:

{code}
localRepo.getProtocol()
{code}

return null. This would explain y it always works in linux but not in windows... I've absolutely
no idea y this line returns null? Replacing localRepo.getProcol() with "file" works like a
charm, but I'm afraid this is not the solution we want to have, do we? :)

> features-maven-plugin does not work with maven 3
> ------------------------------------------------
>
>                 Key: KARAF-244
>                 URL: https://issues.apache.org/jira/browse/KARAF-244
>             Project: Karaf
>          Issue Type: Bug
>          Components: tooling
>    Affects Versions: 2.1.0
>            Reporter: Bengt Rodehav
>            Assignee: Jean-Baptiste Onofré
>
> Now that maven 3 has been released, I think it is important to get the features-maven-plugin
to work under maven 3. The problem is that you normally use "mvn:" url's in the features-maven-plugin,
e g:
>   <build>
>     <plugins>
>       <plugin>
>         <groupId>org.apache.karaf.tooling</groupId>
>         <artifactId>features-maven-plugin</artifactId>
>         <executions>
>           <execution>
>             <id>add-features-to-repo</id>
>             <phase>generate-resources</phase>
>             <goals>
>               <goal>add-features-to-repo</goal>
>             </goals>
>             <configuration>
>               <descriptors>
>                 <descriptor>mvn:org.apache.karaf/apache-karaf/${karaf-version}/xml/features</descriptor>
>               </descriptors>
>               <features>
>                 <feature>ssh</feature>
>                 <feature>management</feature>
>                 <feature>webconsole</feature>
>               </features>
>               <repository>${project.build.directory}/features-repo</repository>
>             </configuration>
>           </execution>
>         </executions>
>       </plugin>
> But the url handler for "mvn:" does not work under maven 3 due to changes in the classpath
handling. An alternative must be developed. I've noticed on the ops4j mailing list that something
called pax-url-aether is in the works. Maybe that's an option for features-maven-plugin?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message