Mailing-List: contact issues-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@karaf.apache.org
Message-ID: <9909051.231421281352760018.JavaMail.jira@thor>
Date: Mon, 9 Aug 2010 07:19:20 -0400 (EDT)
From: "Ioannis Canellos (JIRA)" <jira@apache.org>
To: issues@karaf.apache.org
Subject: [jira] Updated: (KARAF-133) NPE when installing a bundle with a
 MANIFEST.MF not in the first entry of the zip
In-Reply-To: <31964519.494411279709209861.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/KARAF-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ioannis Canellos updated KARAF-133:
-----------------------------------

    Attachment: manifest-not-found-patch.txt

I am attaching a patch that adds a simple check on the manifest object and throws a BundleException with a message "Manifest not present in the first entry of the zip" if the Manifest object is null.


> NPE when installing a bundle with a MANIFEST.MF not in the first entry of the zip
> ---------------------------------------------------------------------------------
>
>                 Key: KARAF-133
>                 URL: https://issues.apache.org/jira/browse/KARAF-133
>             Project: Karaf
>          Issue Type: Bug
>            Reporter: Guillaume Nodet
>            Priority: Trivial
>         Attachments: manifest-not-found-patch.txt
>
>
> I don't think we should necesseraly support those jars, as it would force us to download the whole jar, but we should at least throw a meaningful exception
> {code}
> java.lang.NullPointerException
> 	at org.apache.karaf.features.internal.FeaturesServiceImpl.installBundleIfNeeded(FeaturesServiceImpl.java:560)
> 	at org.apache.karaf.features.internal.FeaturesServiceImpl.doInstallFeature(FeaturesServiceImpl.java:401)
> 	at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeatures(FeaturesServiceImpl.java:246)
> 	at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:235)
> 	at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:231)
> 	at org.apache.karaf.features.command.InstallFeatureCommand.doExecute(InstallFeatureCommand.java:51)
> 	at org.apache.karaf.features.command.FeaturesCommandSupport.doExecute(FeaturesCommandSupport.java:39)
> 	at org.apache.karaf.shell.console.OsgiCommandSupport.execute(OsgiCommandSupport.java:41)
> 	at org.apache.felix.gogo.commands.basic.AbstractCommand.execute(AbstractCommand.java:35)
> 	at org.apache.felix.gogo.runtime.shell.CommandProxy.execute(CommandProxy.java:50)
> 	at org.apache.felix.gogo.runtime.shell.Closure.execute(Closure.java:229)
> 	at org.apache.felix.gogo.runtime.shell.Closure.executeStatement(Closure.java:162)
> 	at org.apache.felix.gogo.runtime.shell.Pipe.run(Pipe.java:101)
> 	at org.apache.felix.gogo.runtime.shell.Closure.execute(Closure.java:79)
> 	at org.apache.felix.gogo.runtime.shell.CommandSessionImpl.execute(CommandSessionImpl.java:71)
> 	at org.apache.karaf.shell.console.jline.Console.run(Console.java:180)
> 	at java.lang.Thread.run(Thread.java:637)
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.