From dev-return-13436-archive-asf-public=cust-asf.ponee.io@karaf.apache.org Tue Feb 5 15:23:55 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 45E78180608 for ; Tue, 5 Feb 2019 16:23:55 +0100 (CET) Received: (qmail 61857 invoked by uid 500); 5 Feb 2019 15:23:49 -0000 Mailing-List: contact dev-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list dev@karaf.apache.org Received: (qmail 61846 invoked by uid 99); 5 Feb 2019 15:23:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Feb 2019 15:23:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5F65AC2777 for ; Tue, 5 Feb 2019 15:23:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.474 X-Spam-Level: *** X-Spam-Status: No, score=3.474 tagged_above=-999 required=6.31 tests=[FREEMAIL_ENVFROM_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, MIME_BOUND_DIGITS_15=1.225, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id yLSXbzrPgtiX for ; Tue, 5 Feb 2019 15:23:46 +0000 (UTC) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 015C560FB2 for ; Tue, 5 Feb 2019 15:16:32 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id j15so2921839lfh.5 for ; Tue, 05 Feb 2019 07:16:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=cdWDuClusAbYAUZdkYGIe597i7+b7pKTno9Qg8cvo8E=; b=PB6jPDl1BTguONoguqmfp0RiomVhbIyyuQB+R0BX0LRLq41x0O7Utkev18RyjMsul7 /QEpbsJ2dRF6qqfwchWBaP3PJazxDgm10mf9FBylYYJv+gYeuTWb1ng1rudQmyGJEn95 dHxZHmERT8bp8FhkV4hnopOu283l7BpbaVQVv/Qh4G/avcdo+YSMxoo5qZ4eLaaz+Qlh cwuxRp7+txxRjiomTU7xckL+Wre3W28ASjtK7iiTHKQmVQuHMlbZPF15Wtefr7cPcdcL ke0l/8y3d9NmjwI+4x+xgd5kc3NFouzsG7ybxMABK8g3Nx4XBmqO5wKoh3p9XZzns/xD Nf2g== X-Gm-Message-State: AHQUAuYQ9BtDyLLPPqgqTcocXzG0ZPuFWdpj8e0z08Z9ijdqsFRpNiv+ GK+02uB49O4lg6UpLETi8NjnB2JlX+vh0DyHK3pWuoVHuCg= X-Google-Smtp-Source: AHgI3IbohvAG21UaIZQ9y36GjlE6GbUw6ApLoNG4NbGpZMAemuJWt3Z1gmb1xAQtLxF+OPmIjIg63DViWlA6jY6hNNM= X-Received: by 2002:ac2:54b9:: with SMTP id w25mr3422823lfk.15.1549379791174; Tue, 05 Feb 2019 07:16:31 -0800 (PST) MIME-Version: 1.0 References: <2f798d05-0a77-6f6c-5bab-ad28f461f613@nanthrax.net> <7daf721d-44f6-bde0-d1c5-3c8f0f265e08@nanthrax.net> In-Reply-To: From: Christian Schneider Date: Tue, 5 Feb 2019 16:16:19 +0100 Message-ID: Subject: Re: [VOTE] Apache Karaf (runtime) 4.2.3 release To: dev@karaf.apache.org Content-Type: multipart/alternative; boundary="0000000000001341720581271842" --0000000000001341720581271842 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I found the reason. The jdbc feature installs the pax-jdbc feature which installs the pax-jdbc bundle. This bundle creates one DataSourceFactory for all jdbc drivers it finds. This is the source of the duplicate DataSourceFactories. We should not install pax-jdbc feature in the karaf jdbc feature as this makes it harder to use proper drivers that already provide good DataSourceFactories. If we do this then of course this means we will have to re add the adapter bundle to pax-jdbc-derby. On the other hand whenever some installs the feature by hand we will also get into the situation of duplicate DSFs. WDYT? Christian Am Di., 5. Feb. 2019 um 15:36 Uhr schrieb Grzegorz Grzybek < gr.grzybek@gmail.com>: > Indeed ;) > > karaf@root()> bundle:services -p 45 > karaf@root()> feature:install jdbc > karaf@root()> bundle:services -p 45 > > Apache Derby 10.14 (45) provides: > --------------------------------- > objectClass =3D [org.osgi.service.jdbc.DataSourceFactory] > osgi.jdbc.driver.class =3D org.apache.derby.jdbc.AutoloadedDriver > osgi.jdbc.driver.name =3D derby > osgi.jdbc.driver.version =3D 10.14.2000000.1828579 > service.bundleid =3D 45 > service.id =3D 88 > service.scope =3D singleton > > regards > Grzegorz Grzybek > > wt., 5 lut 2019 o 15:34 Jean-Baptiste Onofr=C3=A9 napis= a=C5=82(a): > > > Hi Christian, > > > > you have to install the jdbc feature, it will work. > > > > That has been found yesterday evening, already created the Jira at Pax > > JDBC. I have to check why Karaf jdbc feature makes the derby > > DataSourceFactory available. > > > > Regards > > JB > > > > On 05/02/2019 15:28, Christian Schneider wrote: > > > I just tried the derby data source: > > > > > > feature:install pax-jdbc-derby pax-jdbc-config pax-jdbc-pool-dbcp2 > > > service:list DataSourceFactory > > > > > > I see no services of this type. So it seems the derby bundle does not > > offer > > > a DataSourceFactory. > > > > > > Christian > > > > > > Am Di., 5. Feb. 2019 um 10:57 Uhr schrieb Jean-Baptiste Onofr=C3=A9 < > > > jb@nanthrax.net>: > > > > > >> Hi all, > > >> > > >> I submit Apache Karaf (runtime) 4.2.3 to your vote. This is a > > >> maintenance release on the 4.2.x series, bringing some improvements > and > > >> bug fixes. > > >> NB: Once this release vote passed, I will create the karaf-4.2.x > branch > > >> and master will become 4.3.x. Obviously karaf-4.2.x will be an activ= e > > >> branch and I already plan to prepare 4.2.4 release. > > >> > > >> Release Notes: > > >> > > >> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=3D123111= 40&version=3D12344587 > > >> > > >> Staging Repository: > > >> > https://repository.apache.org/content/repositories/orgapachekaraf-1125/ > > >> > > >> Git Tag: > > >> karaf-4.2.3 > > >> > > >> Please vote to approve this release: > > >> > > >> [ ] +1 Approve the release > > >> [ ] -1 Don't approve the release (please provide specific comments) > > >> > > >> This vote will be open for at least 72 hours. > > >> > > >> Thanks, > > >> Regards > > >> JB > > >> -- > > >> Jean-Baptiste Onofr=C3=A9 > > >> jbonofre@apache.org > > >> http://blog.nanthrax.net > > >> Talend - http://www.talend.com > > >> > > > > > > > > > > -- > > Jean-Baptiste Onofr=C3=A9 > > jbonofre@apache.org > > http://blog.nanthrax.net > > Talend - http://www.talend.com > > > --=20 --=20 Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com --0000000000001341720581271842--