From dev-return-13228-archive-asf-public=cust-asf.ponee.io@karaf.apache.org Mon Dec 3 15:49:18 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D7F72180645 for ; Mon, 3 Dec 2018 15:49:17 +0100 (CET) Received: (qmail 18821 invoked by uid 500); 3 Dec 2018 14:49:17 -0000 Mailing-List: contact dev-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list dev@karaf.apache.org Received: (qmail 18794 invoked by uid 99); 3 Dec 2018 14:49:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2018 14:49:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id F2BD3C05DD for ; Mon, 3 Dec 2018 14:49:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.8 X-Spam-Level: X-Spam-Status: No, score=0.8 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id DOiZUENswMLQ for ; Mon, 3 Dec 2018 14:49:14 +0000 (UTC) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4917A5F180 for ; Mon, 3 Dec 2018 14:49:14 +0000 (UTC) X-Originating-IP: 82.238.224.4 Received: from [192.168.134.110] (bre91-1-82-238-224-4.fbx.proxad.net [82.238.224.4]) (Authenticated sender: jb@nanthrax.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 1DBBA1BF215 for ; Mon, 3 Dec 2018 14:49:07 +0000 (UTC) Subject: Re: Bad commit https://github.com/apache/karaf/commit/62e832c7009b5b8beafd219ff7b6b66051205682 To: dev@karaf.apache.org References: <75b18fc4-98ff-9967-aedf-a6ff97c2bb29@nanthrax.net> From: =?UTF-8?Q?Jean-Baptiste_Onofr=c3=a9?= Message-ID: <99d44ca4-c591-25cc-dd43-e459786f7b44@nanthrax.net> Date: Mon, 3 Dec 2018 15:49:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <75b18fc4-98ff-9967-aedf-a6ff97c2bb29@nanthrax.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit OK, I found the issue, it's related to property placeholder: https://issues.apache.org/jira/browse/CAMEL-12570 So, it affects users when using property placeholder in the camel blueprint route. To work, users have to use at least Camel 2.21.2. If an user still uses Camel 2.20.1, it won't work. That's why I think it's better to: 1. stay with blueprint-core 1.9.x on Karaf 4.2.x 2. do a a new blueprint-core 1.9.1 release including the interceptor fix we need for jpa Thoughts ? Regards JB On 03/12/2018 15:43, Jean-Baptiste Onofré wrote: > I just tested camel-blueprint 2.20.1 with blueprint-core 1.10.0 and it > seems to work: I deployed a simple camel route written using blueprint > and it starts and works fine. > > Does someone remember the issue we had with the blueprint-core upgrade > with camel-blueprint ? Maybe it was with previous Camel version. > > Regards > JB > > On 03/12/2018 15:26, Jean-Baptiste Onofré wrote: >> Hi guys, >> >> A pull request has been merged on master (so for Karaf 4.2.2), but I >> think it's not correct: >> >> https://github.com/apache/karaf/commit/62e832c7009b5b8beafd219ff7b6b66051205682 >> >> This is an upgrade to blueprint-core 1.10.0. We already have a Jira >> about that: >> >> https://issues.apache.org/jira/browse/KARAF-5942 >> >> We can't update to blueprint 1.10.0 on Karaf 4.2.x without breaking the >> Camel Blueprint support, which I think it's really bad. >> >> So, I think it would be better to revert this update and target >> blueprint 1.10.0 to Karaf 4.3.x. >> >> Thoughts ? >> >> Regards >> JB >> > -- Jean-Baptiste Onofré jbonofre@apache.org http://blog.nanthrax.net Talend - http://www.talend.com