karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Baptiste Onofré ...@nanthrax.net>
Subject Re: PR608 - Updated Scheduler feature to support persistence - Failed
Date Tue, 11 Sep 2018 08:14:46 GMT
Hi,

Catcha. I will provide my comments directly in the PR.

Regards
JB

On 11/09/2018 09:12, Miroslav Beranič wrote:
> Hi JB,
> 
> yes, I know. I need Quartz API, so this was my main motivation. I guess not
> all changes are valid.
> Open for any suggestion, let me know.
> 
> Regards,
> Miroslav
> 
> 
> V V tor., 11. sep. 2018 ob 08:49 je oseba Jean-Baptiste Onofré <
> jb@nanthrax.net> napisala:
> 
>> Hi,
>>
>> The ASF headers are missing.
>>
>> By the way, I see a lot of incoherent changes here and not good IMHO.
>>
>> I will do a complete review.
>>
>> Regards
>> JB
>>
>> On 11/09/2018 08:35, Miroslav Beranič wrote:
>>> Hi,
>>>
>>> I've subscribed to dev mailing list.
>>>
>>> I've submitted a pull request at
>> https://github.com/apache/karaf/pull/608,
>>> but I see Jenkins build failed do to:
>>> Caused by: org.apache.rat.mp.RatCheckException: Too many files with
>>> unapproved license: 4 See RAT report in:
>>>
>> /home/jenkins/jenkins-slave/workspace/karaf-pr/target/karaf-4.2.2-SNAPSHOT.rat
>>>
>>>
>>> located at :
>>> https://builds.apache.org/job/karaf-pr/665/console
>>>
>>> What should I update, to make this work?
>>>
>>> Kind Regards,
>>> Miroslav
>>>
>>>
>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
> 
> 

-- 
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Mime
View raw message