Mailing-List: contact dev-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Subject: Re: 4.1.4 release in December
To: dev@karaf.apache.org
References: <AC9375B8-2640-4B49-A54B-23706893AE16@code-house.org>
 <9cc137ad-710a-0e5b-133e-1273d7d24051@nanthrax.net>
 <978eb844-a6ae-fa78-428c-706b5b4b78b9@nanthrax.net>
 <E7D507AF-4CED-4742-B074-1D84C28161CE@code-house.org>
From: =?UTF-8?Q?Jean-Baptiste_Onofr=c3=a9?= <jb@nanthrax.net>
Message-ID: <3a748419-e9d9-3456-5f4c-dfd1ff3e0221@nanthrax.net>
Date: Mon, 11 Dec 2017 07:20:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <E7D507AF-4CED-4742-B074-1D84C28161CE@code-house.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
archived-at: Mon, 11 Dec 2017 06:20:42 -0000

No problem !

It happens sometime when cherry-pick ;)

Regards
JB

On 12/10/2017 10:59 PM, luke@code-house.org wrote:
> Hey Jean,
> Yeah, I was committing this changes and obviously I missed a file which I had to bring back from 4.2.x test infra to 4.1.x. I was aware that this change is risky, however I didn’t get any Jenkins notification about build failure which made me think that everything went fine. It is my fault that I didn’t check CI build.
> 
> Thank you very much for taking care about that, and once more - sorry for breaking it.
> 
> Kind regards,
> Lukasz
> 
> 
>> On 10 Dec 2017, at 07:09, Jean-Baptiste Onofré <jb@nanthrax.net> wrote:
>>
>> Just fixed it.
>>
>> Regards
>> JB
>>
>> On 12/10/2017 06:48 AM, Jean-Baptiste Onofré wrote:
>>> By the way,
>>> I saw that you merged/cherry-picked the addition of LDAPPubkeyLoginModule.
>>> However, I guess you didn't test on Karaf 4.1.x branch and you broke the build:
>>> https://builds.apache.org/view/K/view/Karaf/job/karaf-4.1.x/361/
>>> [INFO] -------------------------------------------------------------
>>> [ERROR] COMPILATION ERROR :
>>> [INFO] -------------------------------------------------------------
>>> [ERROR] /home/jenkins/jenkins-slave/workspace/karaf-4.1.x/jaas/modules/src/test/java/org/apache/karaf/jaas/modules/ldap/LDAPPubkeyLoginModuleTest.java:[26,44] cannot find symbol
>>>    symbol:   class PrincipalHelper
>>>    location: package org.apache.karaf.jaas.modules
>>> I'm fixing it now.
>>> Please, at least run a full build before pushing.
>>> Thanks,
>>> Regards
>>> JB
>>> On 12/10/2017 12:03 AM, Łukasz Dywicki wrote:
>>>> Hey folks,
>>>> I wanted to check with you if there is any work planned to be done with 4.1.x branch this month, as I would like to push some fixes & flush them out.
>>>> These are needed for OpenHab community, which might not be as big as ODL but, it does run into troubles from time to time.
>>>>
>>>> As I never handled release, despite of having such possibility, I could try to do it and offload „standard” team members handling this task.
>>>>
>>>> Cheers,
>>>> Łukasz Dywicki
>>>>
>>
>> -- 
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
> 

-- 
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com