Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D29C8200C54 for ; Wed, 12 Apr 2017 21:32:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D1102160B95; Wed, 12 Apr 2017 19:32:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 25390160B85 for ; Wed, 12 Apr 2017 21:32:20 +0200 (CEST) Received: (qmail 4012 invoked by uid 500); 12 Apr 2017 19:32:20 -0000 Mailing-List: contact dev-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list dev@karaf.apache.org Received: (qmail 3997 invoked by uid 99); 12 Apr 2017 19:32:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Apr 2017 19:32:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 887BDC9C6E for ; Wed, 12 Apr 2017 19:32:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.093 X-Spam-Level: ** X-Spam-Status: No, score=2.093 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, URI_HEX=1.313] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id vVK1N4qTH_3Q for ; Wed, 12 Apr 2017 19:32:17 +0000 (UTC) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id B9DBA5FC4A for ; Wed, 12 Apr 2017 19:32:16 +0000 (UTC) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by relay7-d.mail.gandi.net (Postfix) with ESMTPS id B1808E09 for ; Wed, 12 Apr 2017 21:32:15 +0200 (CEST) Received: from mfilter11-d.gandi.net (mfilter11-d.gandi.net [217.70.178.131]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id 9C6A0A80DF for ; Wed, 12 Apr 2017 21:32:15 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mfilter11-d.gandi.net Received: from relay3-d.mail.gandi.net ([IPv6:::ffff:217.70.183.195]) by mfilter11-d.gandi.net (mfilter11-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id 47Dl5ead3vjo for ; Wed, 12 Apr 2017 21:32:14 +0200 (CEST) X-Originating-IP: 82.238.224.4 Received: from [192.168.134.75] (bre91-1-82-238-224-4.fbx.proxad.net [82.238.224.4]) (Authenticated sender: jb@nanthrax.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 06FFAA80CF for ; Wed, 12 Apr 2017 21:32:13 +0200 (CEST) Subject: Re: Unit tests and refactoring - karaf-maven-plugin - AssemblyMojo To: dev@karaf.apache.org References: <1492019496301-4050109.post@n3.nabble.com> <1492021215223-4050111.post@n3.nabble.com> From: =?UTF-8?Q?Jean-Baptiste_Onofr=c3=a9?= Message-ID: <89ea98bd-77fa-0d3e-4928-0b9c3582974e@nanthrax.net> Date: Wed, 12 Apr 2017 21:32:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1492021215223-4050111.post@n3.nabble.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit archived-at: Wed, 12 Apr 2017 19:32:22 -0000 Hi, The DependencyHelper is able to deal with Maven/Aether dependency backend. Upgrading will allow to use Maven dependency directly. Regards JB On 04/12/2017 08:20 PM, kemitix wrote: > Hi Jean-Baptiste, > > Great. Enforcer has requireMavenVersion 3.3.9,4 already so I don't think > it's caring about what dependencies are used within the module. Tooling is > currently using Maven 3.0.3. > > Is there a reason to keep the Dependency30Helper class in tooling.utils? > Once the tooling module is upgraded to not use Maven 3.0 is there a reason > why would this class needs to stay? Enforcer appears to already block use by > 3.0 on the command line. I've not use Enforcer before, so I may be > misunderstanding what it does. > > Dependency31Helper can then be rewritten to use the Maven API directly, as > noted in the javadoc. > > If there's no reason to keep the 3.0 helper, I'll delete it rather than > rewriting it to use reflection. > > ... then I can get back to writing tests for AssemblyMojo. :) > > Regard > Paul Campbell > > > > -- > View this message in context: http://karaf.922171.n3.nabble.com/Unit-tests-and-refactoring-karaf-maven-plugin-AssemblyMojo-tp4050098p4050111.html > Sent from the Karaf - Dev mailing list archive at Nabble.com. > -- Jean-Baptiste Onofr jbonofre@apache.org http://blog.nanthrax.net Talend - http://www.talend.com