From dev-return-11569-apmail-karaf-dev-archive=karaf.apache.org@karaf.apache.org Wed Jan 25 14:15:30 2017 Return-Path: X-Original-To: apmail-karaf-dev-archive@minotaur.apache.org Delivered-To: apmail-karaf-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C8D4C196EB for ; Wed, 25 Jan 2017 14:15:30 +0000 (UTC) Received: (qmail 41414 invoked by uid 500); 25 Jan 2017 14:15:30 -0000 Delivered-To: apmail-karaf-dev-archive@karaf.apache.org Received: (qmail 41377 invoked by uid 500); 25 Jan 2017 14:15:30 -0000 Mailing-List: contact dev-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list dev@karaf.apache.org Received: (qmail 41364 invoked by uid 99); 25 Jan 2017 14:15:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2017 14:15:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D5CBF18495F for ; Wed, 25 Jan 2017 14:15:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.03 X-Spam-Level: * X-Spam-Status: No, score=1.03 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 1qeZv1FtytId for ; Wed, 25 Jan 2017 14:15:26 +0000 (UTC) Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id CB3A65FC06 for ; Wed, 25 Jan 2017 14:15:25 +0000 (UTC) Received: by mail-wm0-f43.google.com with SMTP id d140so52365175wmd.0 for ; Wed, 25 Jan 2017 06:15:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=AI0laml+Er43bW+WDMIyCTF6Z4Fvd0cE3qM1L/g2MMA=; b=Y4gSsXTwka84fcZTDkane1vpnijwldC8TOVM974Nbwj/aQ0XD+5MRs3HQUAzGAtmx2 ynZ//f6o4t51Y6MWij+RjWtRwizTo6jTvA21k71yk9GHRy5cgVQPkMOIaJiNH+AWUsmW FlBS1QCWiRHOmBs6FrORbg+1UxG922topg0p4rRsJr2VQvJwGgleUd0r0D9Sz63kZh28 7fCql5x4m9fezdGgBq8TPzpNPKk/q8wTnxzCCWpgL2I0Vh3JvYktvdKplPrVRIVH7h0c H9oNbOMrxW5nQnHibBqviG/kaLGm49OwWuQlfSSsRU3X5Uuzl/j1AbYR816qmJcRclzB 2xEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=AI0laml+Er43bW+WDMIyCTF6Z4Fvd0cE3qM1L/g2MMA=; b=uaCOLzf8h+sbdbBS0tkDeMi14KrSbQXsr5aZ7ynaYJ6LpydLjOGeyhfJ8qCxOuAy9y y56OKnigL1zmHfSI/0+BLvaf9pfX/g9jvU8tsdqt28IQLvW1dldXdyqP6Bsy/KE3iB6P VGytiiRbqv0ha9ieDgmdJhKCXwIjZdwytbasI66MeEKSOI6jGGl42dsIVntIMxINn/7t ZT5h1wRLUVxDmaIFMWftIL9HtrNgDCD2mC+wJcJrcPMwf+v9RON5xuou+saSirotPNuO ZHVSk1K6CLn149SENMrzU6PK8srnB+Jascj6Kqgh88tSXp0w9kWbYTXBg67L6J2ZNIU6 JKKA== X-Gm-Message-State: AIkVDXK2Bwznjcija+YqYD/ZDcY6AcnxboTZdK2slryVOiQUu+oFmaRVEG+ksRsp6CdF1A== X-Received: by 10.223.147.130 with SMTP id 2mr29992719wrp.53.1485353724545; Wed, 25 Jan 2017 06:15:24 -0800 (PST) Received: from [192.168.0.118] (HSI-KBW-149-172-37-189.hsi13.kabel-badenwuerttemberg.de. [149.172.37.189]) by smtp.googlemail.com with ESMTPSA id k70sm13230238wmc.3.2017.01.25.06.15.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jan 2017 06:15:24 -0800 (PST) Sender: Christian Schneider Subject: Re: karaf git commit: [KARAF-4931] - Static profile generation fails if configfile element contains a placeholder To: dev@karaf.apache.org References: <6b7c1db174c84acf9a142caffd105851@git.apache.org> <565815a4-9d4f-6b2f-1906-df57afd5a896@die-schneider.net> From: Christian Schneider Message-ID: <9b46ba36-f588-45ee-3cf3-c96e34831bf2@die-schneider.net> Date: Wed, 25 Jan 2017 15:15:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Guillaume is currently fixing it. Christian On 25.01.2017 15:13, Achim Nierbeck wrote: > That is rather strange, as I changed Karaf [1] for that prior fixing the > corresponding issue at Pax Web [2]. > > right now I don't have much time, so I'd need to check tonight. But it did > work before, so was there another change to the Profiles? > > regards, Achim > > [1] - https://issues.apache.org/jira/browse/KARAF-4931 > [2] - https://ops4j1.jira.com/browse/PAXWEB-999 > > > 2017-01-25 14:56 GMT+01:00 Christian Schneider : > >> Hi Achim, >> >> the current karaf build fails at the demo of the static profile and at the >> archetype assembly. >> In both places the property replacement seems to be the cause. >> >> See the error below. >> >> Can you please check what is going on there? >> >> Christian >> >> [INFO] [ERROR] Failed to execute goal org.apache.karaf.tooling:karaf >> -maven-plugin:4.1.0-SNAPSHOT:assembly (default-assembly) on project >> assembly: Unable to build assembly: Error downloading configuration files >> -> [Help 1] >> [INFO] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to >> execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.1.0-SNAPSHOT:assembly >> (default-assembly) on project assembly: Unable to build assembly >> [INFO] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(Moj >> oExecutor.java:212) >> [INFO] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(Moj >> oExecutor.java:153) >> [INFO] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(Moj >> oExecutor.java:145) >> [INFO] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.b >> uildProject(LifecycleModuleBuilder.java:116) >> [INFO] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.b >> uildProject(LifecycleModuleBuilder.java:80) >> [INFO] at org.apache.maven.lifecycle.internal.builder.singlethreaded.S >> ingleThreadedBuilder.build(SingleThreadedBuilder.java:51) >> [INFO] at org.apache.maven.lifecycle.internal.LifecycleStarter.execute >> (LifecycleStarter.java:128) >> [INFO] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:30 >> 7) >> [INFO] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:19 >> 3) >> [INFO] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106) >> [INFO] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863) >> [INFO] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288) >> [INFO] at org.apache.maven.cli.MavenCli.main(MavenCli.java:199) >> [INFO] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> [INFO] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce >> ssorImpl.java:62) >> [INFO] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe >> thodAccessorImpl.java:43) >> [INFO] at java.lang.reflect.Method.invoke(Method.java:498) >> [INFO] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnha >> nced(Launcher.java:289) >> [INFO] at org.codehaus.plexus.classworlds.launcher.Launcher.launch( >> Launcher.java:229) >> [INFO] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithEx >> itCode(Launcher.java:415) >> [INFO] at org.codehaus.plexus.classworlds.launcher.Launcher.main( >> Launcher.java:356) >> [INFO] Caused by: org.apache.maven.plugin.MojoExecutionException: Unable >> to build assembly >> [INFO] at org.apache.karaf.tooling.AssemblyMojo.execute(AssemblyMojo. >> java:268) >> [INFO] at org.apache.maven.plugin.DefaultBuildPluginManager.executeMoj >> o(DefaultBuildPluginManager.java:134) >> [INFO] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(Moj >> oExecutor.java:207) >> [INFO] ... 20 more >> [INFO] Caused by: java.io.IOException: Error downloading configuration >> files >> [INFO] at org.apache.karaf.profile.assembly.AssemblyDeployCallback.ins >> tallFeature(AssemblyDeployCallback.java:180) >> [INFO] at org.apache.karaf.features.internal.service.Deployer.deploy( >> Deployer.java:823) >> [INFO] at org.apache.karaf.profile.assembly.Builder.resolve(Builder. >> java:1392) >> [INFO] at org.apache.karaf.profile.assembly.Builder.startupStage(Build >> er.java:1182) >> [INFO] at org.apache.karaf.profile.assembly.Builder.doGenerateAssembly >> (Builder.java:658) >> [INFO] at org.apache.karaf.profile.assembly.Builder.generateAssembly( >> Builder.java:440) >> [INFO] at org.apache.karaf.tooling.AssemblyMojo.doExecute(AssemblyMojo >> .java:506) >> [INFO] at org.apache.karaf.tooling.AssemblyMojo.execute(AssemblyMojo. >> java:262) >> [INFO] ... 22 more >> [INFO] Caused by: org.apache.karaf.features.internal.util.MultiException: >> Error >> [INFO] at org.apache.karaf.features.internal.download.impl.MavenDownlo >> adManager$MavenDownloader.(MavenDownloadManager.java:84) >> [INFO] at org.apache.karaf.profile.assembly.CustomDownloadManager$Cust >> omMavenDownloader.(CustomDownloadManager.java:58) >> [INFO] at org.apache.karaf.profile.assembly.CustomDownloadManager.crea >> teDownloader(CustomDownloadManager.java:55) >> [INFO] at org.apache.karaf.profile.assembly.AssemblyDeployCallback.ins >> tallFeature(AssemblyDeployCallback.java:148) >> [INFO] ... 29 more >> [INFO] Suppressed: java.nio.file.NoSuchFileException: >> /home/cschneider/checkout/karaf/archetypes/assembly/target/ >> test-classes/projects/assembly/project/assembly/target/ >> assembly/${karaf.etc}/jetty.xml >> >> >> >> On 12.01.2017 19:52, anierbeck@apache.org wrote: >> >>> Repository: karaf >>> Updated Branches: >>> refs/heads/master 715d236f5 -> e6e0928b9 >>> >>> >>> [KARAF-4931] - Static profile generation fails if configfile element >>> contains a placeholder >>> >>> Project: http://git-wip-us.apache.org/repos/asf/karaf/repo >>> Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/e6e0928b >>> Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/e6e0928b >>> Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/e6e0928b >>> >>> Branch: refs/heads/master >>> Commit: e6e0928b99675a2735a9c3b8927e93520ff32eac >>> Parents: 715d236 >>> Author: anierbeck >>> Authored: Thu Jan 12 18:51:28 2017 +0000 >>> Committer: anierbeck >>> Committed: Thu Jan 12 18:51:28 2017 +0000 >>> >>> ---------------------------------------------------------------------- >>> .../assembly/AssemblyDeployCallback.java | 21 >>> +++++++++++++++++++- >>> 1 file changed, 20 insertions(+), 1 deletion(-) >>> ---------------------------------------------------------------------- >>> >>> >>> http://git-wip-us.apache.org/repos/asf/karaf/blob/e6e0928b/p >>> rofile/src/main/java/org/apache/karaf/profile/assembly/Assem >>> blyDeployCallback.java >>> ---------------------------------------------------------------------- >>> diff --git a/profile/src/main/java/org/apache/karaf/profile/assembly/AssemblyDeployCallback.java >>> b/profile/src/main/java/org/apache/karaf/profile/assembly/As >>> semblyDeployCallback.java >>> index 2c4a09b..f86b682 100644 >>> --- a/profile/src/main/java/org/apache/karaf/profile/assembly/As >>> semblyDeployCallback.java >>> +++ b/profile/src/main/java/org/apache/karaf/profile/assembly/As >>> semblyDeployCallback.java >>> @@ -151,7 +151,7 @@ public class AssemblyDeployCallback implements >>> Deployer.DeployCallback { >>> @Override >>> public void downloaded(StreamProvider provider) throws >>> Exception { >>> Path input = provider.getFile().toPath(); >>> - String path = configFile.getFinalname(); >>> + String path = substFinalName(configFile.getF >>> inalname()); >>> if (path.startsWith("/")) { >>> path = path.substring(1); >>> } >>> @@ -266,4 +266,23 @@ public class AssemblyDeployCallback implements >>> Deployer.DeployCallback { >>> @Override >>> public void replaceDigraph(Map>> Set>>> policies, Map> bundles) throws >>> BundleException, InvalidSyntaxException { >>> } >>> + >>> + private String substFinalName(String finalname) { >>> + final String markerVarBeg = "${"; >>> + final String markerVarEnd = "}"; >>> + >>> + boolean startsWithVariable = finalname.startsWith(markerVarBeg) >>> && finalname.contains(markerVarEnd); >>> + if (startsWithVariable) { >>> + String marker = finalname.substring(markerVarBeg.length(), >>> finalname.indexOf(markerVarEnd) - 1); >>> + switch (marker) { >>> + case "karaf.base": >>> + return this.homeDirectory + "/" + >>> finalname.substring(finalname.indexOf(markerVarEnd)+markerVa >>> rEnd.length()); >>> + case "karaf.etc": >>> + return this.etcDirectory + "/" + >>> finalname.substring(finalname.indexOf(markerVarEnd)+markerVa >>> rEnd.length()); >>> + default: >>> + break; >>> + } >>> + } >>> + return finalname; >>> + } >>> } >>> >>> >> -- >> Christian Schneider >> http://www.liquid-reality.de >> >> Open Source Architect >> http://www.talend.com >> >> > -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com