karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arnaud Vandyck <avand...@gmail.com>
Subject Re: Build broken on master
Date Mon, 12 Sep 2016 09:43:15 GMT
Only the tests from my pull request have been used but not the java 8
refactoring of the code; plus the two merge requests where used in only one
commit, that's complicated for me to merge the result in my branches.

2016-09-12 11:22 GMT+02:00 Guillaume Nodet <gnodet@apache.org>:

> Fixed, sorry about that.
> Fwiw, the problems were not related to the tests in the PR, which I fixed
> before committing, but from a later commit.
>
> 2016-09-12 11:00 GMT+02:00 Jean-Baptiste Onofré <jb@nanthrax.net>:
>
> > Hi all,
> >
> > following the last commits on the shell grep action, the build is broken
> > on master due to test failures:
> >
> > Tests in error:
> >   GrepTest.testGrep:47->systemInOutDecorator:300 » NullPointer
> >   GrepTest.testGrepCount:86->systemInOutDecorator:300 » NullPointer
> >   GrepTest.testGrepCountInvert:96->systemInOutDecorator:300 »
> NullPointer
> >
> > I gonna fix that.
> >
> > Sorry for the inconvenience.
> >
> > FYI: I started to review the Pull Request and mentioned these tests
> > failures to the contributor. So please, as reminder:
> > 1/ in a pull request, when you see a "R: @..." comments, it means a
> > reviewer started to work on the pull request
> > 2/ merge a pull request only when LGTM is set and the full build is OK
> >
> > Thanks
> > Regards
> > JB
> > --
> > Jean-Baptiste Onofré
> > jbonofre@apache.org
> > http://blog.nanthrax.net
> > Talend - http://www.talend.com
> >
>
>
>
> --
> ------------------------
> Guillaume Nodet
> ------------------------
> Red Hat, Open Source Integration
>
> Email: gnodet@redhat.com
> Web: http://fusesource.com
> Blog: http://gnodet.blogspot.com/
>



-- 
Arnaud Vandyck
http://about.me/avdyk

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message