karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Grzegorz Grzybek <gr.grzy...@gmail.com>
Subject Re: [VOTE] Apache Karaf 4.0.5 release (take 2)
Date Wed, 06 Apr 2016 12:45:53 GMT
Hello

OK, I have a fix and here's an explanation.
First (ARIES-1290), following Java relationship of
org.apache.aries.blueprint.compendium.cm.CmPropertyPlaceholder and
org.apache.aries.blueprint.ext.PropertyPlaceholder I wanted to reflect this
fact at XSD level, so we could mix cm and ext namespace elements.
Then (ARIES-1503) there was a fix for situations, where XSDs were read for
CmNamespaceHandler before ExtNamespaceHandler managed to register itself in
NamespaceRegistryImpl.

And finally (now) the fix (after adding
org.apache.aries.blueprint.NamespaceHandler2#mayResolve() method) is more
conservative - we can resolve not registered namespaces using those
handlers that return true in their implementation of
org.apache.aries.blueprint.NamespaceHandler2#mayResolve() - and there'll be
(now) only one such handler - for cm namespace.

I'm preparing PR.

best regards and I'm very sorry for delay of the release!
Grzegorz Grzybek

2016-04-06 11:50 GMT+02:00 Kevin Carr <kscarr73@gmail.com>:

> I agree option 2.  Best to delay and fix.
>
> On Wed, Apr 6, 2016, 4:49 AM Achim Nierbeck <bcanhome@googlemail.com>
> wrote:
>
> > yeah option 2 sounds best, so here's my -1 on this release ... a major
> bug
> > shouldn't go into any production, especially if we know of it.
> >
> > regards, Achim
> >
> >
> > 2016-04-06 9:47 GMT+02:00 Markus Rathgeb <maggu2810@gmail.com>:
> >
> > > +1 for option 2
> > >
> > > 2016-04-06 8:48 GMT+02:00 Sobkowiak Krzysztof <
> krzys.sobkowiak@gmail.com
> > >:
> > > > I prefer the option 2 as well
> > > >
> > > > Regards
> > > > Krzysztof
> > > >
> > > > On 06.04.2016 08:39, Jean-Baptiste Onofré wrote:
> > > >> Hi Cristiano,
> > > >>
> > > >> I don't think it's related, as the issue in about blueprint-ext
> > > namespace (not even define). The problem is located in Aries Blueprint.
> > > >>
> > > >> I gonna deal with Guillaume.
> > > >>
> > > >> We can:
> > > >> 0. leave Karaf 4.0.5 as it is, but I think it's not acceptable:
> > > blueprint is used by lot of users, and we can't allow a release
> without a
> > > working blueprint layer.
> > > >> 1. downgrade Karaf to Aries Blueprint 1.5.x: unfortunately, we won't
> > > benefit about some improvements implemented in blueprint
> > > >> 2. revert or fix the change in Aries: it means we would need a new
> > > Aries Blueprint core release, so 3 days vote, meaning that we won't be
> > able
> > > to release Karaf before roughly 6 days.
> > > >>
> > > >> My preference is on 2 even if it delays Karaf 4.0.5 release.
> > > >>
> > > >> Thoughts ?
> > > >>
> > > >> I will add an Integration Test on blueprint to avoid such problem
in
> > > the future.
> > > >>
> > > >> Regards
> > > >> JB
> > > >>
> > > >> On 04/06/2016 08:14 AM, Cristiano Costantini wrote:
> > > >>> Hi JB and Krzysztof,
> > > >>>
> > > >>> I don't know if this can be have any impact on the problem you
have
> > > >>> reported, but about 1 month ago I got into an issue with camel
XSD
> > > schemas
> > > >>> for Camel namespaces, and the issue is that the URL of the latest
> > XSD,
> > > >>> http://camel.apache.org/schema/blueprint/camel-blueprint.xsd
> > > >>> is not from latest version 2.16.2, but it is from version 2.15.0
> > > >>>
> > > >>> While upgrading to ServiceMix 7, I had to change manually the
XML
> to
> > > >>> xsi:schemaLocation="http://camel.apache.org/schema/spring
> > http://camel
> > > >>> .apache.org/schema/spring/camel-spring-2.16.1.xsd" in order to
> make
> > > it work
> > > >>> (note also that SMX 7 is based on camel 2.16.2, but this XSD is
not
> > > >>> available)
> > > >>>
> > > >>> But in fact the only problem I had was that Eclipse validation
and
> > > >>> autocompletion of the XML files was not working properly.
> > > >>>
> > > >>> if this is not relevant, please ignore this message ;-)
> > > >>>
> > > >>> Cristiano
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>> Il giorno mar 5 apr 2016 alle ore 22:19 Jean-Baptiste Onofré
<
> > > >>> jb@nanthrax.net> ha scritto:
> > > >>>
> > > >>>> I tried with Camel 2.16.2, camel-blueprint, and simple route
in
> > > >>>> blueprint: it works fine.
> > > >>>>
> > > >>>> I tried with your XML, and actually I have the same problem.
> > > >>>>
> > > >>>> It sounds like a Aries Blueprint bug. Let me try if I downgrade
to
> > > >>>> blueprint 1.5.x and check the change in aries blueprint (I
know
> > > >>>> Guillaume did some enhancements & changes).
> > > >>>>
> > > >>>> Honestly, I would consider as a blocker for the release, so,
I
> will
> > > >>>> probably revert my vote to -1. I just want to make more tests.
> > > >>>>
> > > >>>> Regards
> > > >>>> JB
> > > >>>>
> > > >>>> On 04/05/2016 09:46 PM, Krzysztof Sobkowiak wrote:
> > > >>>>> Hi
> > > >>>>>
> > > >>>>> I tried to upgrade ServiceMix to the new version and have
several
> > > >>>> problems with blueprint.
> > > >>>>>
> > > >>>>> 2016-04-05 21:42:05,485 | INFO  | pool-46-thread-1 |
> > > >>>> FeaturesServiceImpl              | 9 -
> > org.apache.karaf.features.core
> > > -
> > > >>>> 4.0.5 |   cxf-wsn-receive/7.0.0.SNAPSHOT
> > > >>>>> 2016-04-05 21:42:05,567 | ERROR | pool-46-thread-1 |
> > > >>>> BlueprintContainerImpl           | 28 -
> > > org.apache.aries.blueprint.core -
> > > >>>> 1.6.0 | Unable to start blueprint container for bundle
> > > >>>> cxf-wsn-receive/7.0.0.SNAPSHOT
> > > >>>>> org.xml.sax.SAXParseException: src-import.3.1: The namespace
> > > attribute, '
> > > >>>> http://aries.apache.org/blueprint/xmlns/blueprint-ext/v1.0.0',
of
> > an
> > > >>>> <import> element information item must be identical
to the
> > > targetNamespace
> > > >>>> attribute, 'http://camel.apache.org/schema/blueprint', of
the
> > > imported
> > > >>>> document.
> > > >>>>>       at
> > > >>>>
> > >
> >
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> > >
> org.apache.xerces.impl.xs.traversers.XSDHandler.reportSchemaError(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> > >
> org.apache.xerces.impl.xs.traversers.XSDHandler.reportSchemaError(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> > org.apache.xerces.impl.xs.traversers.XSDHandler.constructTrees(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> > org.apache.xerces.impl.xs.traversers.XSDHandler.constructTrees(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> org.apache.xerces.impl.xs.traversers.XSDHandler.parseSchema(Unknown
> > > >>>> Source)[:]
> > > >>>>>
> > > >>>>> or
> > > >>>>>
> > > >>>>>
> > > >>>>> 2016-04-05 21:31:36,969 | ERROR | pool-42-thread-1 |
> > > >>>> BlueprintContainerImpl           | 28 -
> > > org.apache.aries.blueprint.core -
> > > >>>> 1.6.0 | Unable to start blueprint container for bundle
> > > >>>> drools-camel-cxf-server/7.0.0.SNAPSHOT
> > > >>>>> org.xml.sax.SAXParseException: src-import.3.1: The namespace
> > > attribute, '
> > > >>>> http://cxf.apache.org/configuration/beans', of an <import>
> element
> > > >>>> information item must be identical to the targetNamespace
> > attribute, '
> > > >>>> http://camel.apache.org/schema/blueprint', of the imported
> > document.
> > > >>>>>       at
> > > >>>>
> > >
> >
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> > >
> org.apache.xerces.impl.xs.traversers.XSDHandler.reportSchemaError(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> > >
> org.apache.xerces.impl.xs.traversers.XSDHandler.reportSchemaError(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> > org.apache.xerces.impl.xs.traversers.XSDHandler.constructTrees(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> > org.apache.xerces.impl.xs.traversers.XSDHandler.constructTrees(Unknown
> > > >>>> Source)[:]
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>> Here my try to reproduce one of them in K405
> > > >>>>>
> > > >>>>> Assume you have following simple blueprint (I have reduced
one of
> > the
> > > >>>> blueprints from the examples)
> > > >>>>>
> > > >>>>> <blueprint xmlns="http://www.osgi.org/xmlns/blueprint/v1.0.0"
> > > >>>>>              xmlns:xsi="
> http://www.w3.org/2001/XMLSchema-instance"
> > > >>>>>              xmlns:cm="
> > > >>>> http://aries.apache.org/blueprint/xmlns/blueprint-cm/v1.1.0"
> > > >>>>>              xsi:schemaLocation="
> > > >>>> http://www.osgi.org/xmlns/blueprint/v1.0.0
> > > >>>> http://www.osgi.org/xmlns/blueprint/v1.0.0/blueprint.xsd">
> > > >>>>>
> > > >>>>>       <!-- AdminConfig property place holder for the
> > > >>>> org.apache.servicemix.examples.cxf.receive"  -->
> > > >>>>>       <cm:property-placeholder
> > > >>>> persistent-id="org.apache.servicemix.examples.cxf.receive"
> > > >>>> update-strategy="reload">
> > > >>>>>           <cm:default-properties>
> > > >>>>>               <cm:property name="endpoint" value="
> > > >>>> http://localhost:12345/test/"/>
> > > >>>>>               <cm:property name="topic" value="MyTopic"
/>
> > > >>>>>           </cm:default-properties>
> > > >>>>>       </cm:property-placeholder>
> > > >>>>>
> > > >>>>>       <camelContext xmlns="
> > http://camel.apache.org/schema/blueprint
> > > ">
> > > >>>>>
> > > >>>>>       </camelContext>
> > > >>>>> </blueprint>
> > > >>>>>
> > > >>>>>
> > > >>>>> Next
> > > >>>>>
> > > >>>>> karaf@root()> feature:repo-add camel 2.16.2
> > > >>>>> Adding feature url
> > > >>>> mvn:org.apache.camel.karaf/apache-camel/2.16.2/xml/features
> > > >>>>> karaf@root()> feature:install camel-blueprint
> > > >>>>>
> > > >>>>>
> > > >>>>> Deploy the blueprint into deploy directory (the same problem
> occurs
> > > when
> > > >>>> the blueprint is part of a bundle). Tho log contains following
> error
> > > >>>>>
> > > >>>>>
> > > >>>>> 2016-04-05 21:15:47,932 | INFO  | raf-4.0.5/deploy | fileinstall
> > > >>>>                | 8 - org.apache.felix.fileinstall - 3.5.4
|
> > Installing
> > > >>>> bundle x.xml / 0.0.0
> > > >>>>> 2016-04-05 21:15:48,216 | ERROR | raf-4.0.5/deploy |
> > > >>>> BlueprintContainerImpl           | 13 -
> > > org.apache.aries.blueprint.core -
> > > >>>> 1.6.0 | Unable to start blueprint container for bundle x.xml/0.0.0
> > > >>>>> org.xml.sax.SAXParseException: src-import.3.1: The namespace
> > > attribute, '
> > > >>>> http://aries.apache.org/blueprint/xmlns/blueprint-ext/v1.0.0',
of
> > an
> > > >>>> <import> element information item must be identical
to the
> > > targetNamespace
> > > >>>> attribute, 'http://camel.apache.org/schema/blueprint', of
the
> > > imported
> > > >>>> document.
> > > >>>>>       at
> > > >>>>
> > >
> >
> org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> > >
> org.apache.xerces.impl.xs.traversers.XSDHandler.reportSchemaError(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> > >
> org.apache.xerces.impl.xs.traversers.XSDHandler.reportSchemaError(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> > org.apache.xerces.impl.xs.traversers.XSDHandler.constructTrees(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> > org.apache.xerces.impl.xs.traversers.XSDHandler.constructTrees(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> org.apache.xerces.impl.xs.traversers.XSDHandler.parseSchema(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > org.apache.xerces.impl.xs.XMLSchemaLoader.loadSchema(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > org.apache.xerces.impl.xs.XMLSchemaLoader.loadGrammar(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > org.apache.xerces.impl.xs.XMLSchemaLoader.loadGrammar(Unknown
> > > >>>> Source)[:]
> > > >>>>>       at
> > > >>>>
> org.apache.xerces.jaxp.validation.XMLSchemaFactory.newSchema(Unknown
> > > >>>> Source)[:]
> > > >>>>>
> > > >>>>>
> > > >>>>> The same happens with Camel 2.17.0.
> > > >>>>> This error didn't occur in K404. I think, it can be caused
by
> > > upgrade to
> > > >>>> Aries Blueprint 1.6.0.
> > > >>>>>
> > > >>>>>
> > > >>>>> Please, correct me if I'm missing something I should do
after
> this
> > > >>>> upgrade. But when it's a new issue introduced by upgrade to
Aries
> > > Blueprint
> > > >>>> 1.6.0 the people using Camel with Karaf will not be happy
with the
> > new
> > > >>>> version. ServiceMix will be broken too.
> > > >>>>>
> > > >>>>> I'd like to vote with -1, non-binding, but I'm giving
-0. Please
> > > decide,
> > > >>>> whether this is issue which should stop the release.
> > > >>>>>
> > > >>>>> Kindly regards
> > > >>>>> Krzysztof
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>>
> > > >>>>> On 04.04.2016 22:38, Jean-Baptiste Onofré wrote:
> > > >>>>>> Hi all,
> > > >>>>>>
> > > >>>>>> I submit Karaf Container 4.0.5 release to your vote.
> > > >>>>>>
> > > >>>>>> Release Note:
> > > >>>>>>
> > > >>>>
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12334629
> > > >>>>>>
> > > >>>>>> Staging Repository:
> > > >>>>>>
> > >
> https://repository.apache.org/content/repositories/orgapachekaraf-1060/
> > > >>>>>>
> > > >>>>>> Git tag:
> > > >>>>>> karaf-4.0.5
> > > >>>>>>
> > > >>>>>> Please vote to approve this release:
> > > >>>>>>
> > > >>>>>> [ ] +1 Approve the release
> > > >>>>>> [ ] -1 Don't approve the release (please provide specific
> > comments)
> > > >>>>>>
> > > >>>>>> This vote will be open for at least 72 hours.
> > > >>>>>>
> > > >>>>>> Thanks,
> > > >>>>>> Regards
> > > >>>>>> JB
> > > >>>>>
> > > >>>>
> > > >>>> --
> > > >>>> Jean-Baptiste Onofré
> > > >>>> jbonofre@apache.org
> > > >>>> http://blog.nanthrax.net
> > > >>>> Talend - http://www.talend.com
> > > >>>>
> > > >>>
> > > >>
> > > >
> > > > --
> > > > Krzysztof Sobkowiak
> > > >
> > > > JEE & OSS Architect, Integration Architect
> > > > Apache Software Foundation Member (http://apache.org/)
> > > > Apache ServiceMix Committer & PMC Member (
> > http://servicemix.apache.org/)
> > > > Senior Solution Architect @ Capgemini SSC (
> > > http://www.capgeminisoftware.pl/)
> > >
> >
> >
> >
> > --
> >
> > Apache Member
> > Apache Karaf <http://karaf.apache.org/> Committer & PMC
> > OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer
> &
> > Project Lead
> > blog <http://notizblog.nierbeck.de/>
> > Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS>
> >
> > Software Architect / Project Manager / Scrum Master
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message