Mailing-List: contact dev-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Subject: Re: Problems due to the endorsed java.lang.Exception
To: dev@karaf.apache.org
References: 
 <CAAPbCXjT5RDapx=Kt5K5-onF6cbM4mE_Awq9Kqjc+cVXXx6PtQ@mail.gmail.com>
From: =?UTF-8?Q?Jean-Baptiste_Onofr=c3=a9?= <jb@nanthrax.net>
Message-ID: <56EC2CF3.6050708@nanthrax.net>
Date: Fri, 18 Mar 2016 17:29:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: 
 <CAAPbCXjT5RDapx=Kt5K5-onF6cbM4mE_Awq9Kqjc+cVXXx6PtQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Cristiano,

I think you are right, it's probably something existing for a while. I'm 
just surprised that you encountered now.

Let me check your detailed use case that you sent previously.

Regards
JB

On 03/18/2016 05:14 PM, Cristiano Costantini wrote:
> Hello all,
>
> it is some days I was having troubles using CXF services on ServiceMix (and
> it is some days I spam on the mailing list of ServiceMix, Camel and CXF :-D
> ) and I've finally come to the source of my issues which are due to the
> "endorsed" java.lang.Exception which is used by Karaf:
>
> https://github.com/apache/karaf/blob/master/exception/src/main/java/java/lang/Exception.java
>
> My problem is due to the fact that this class has a public property,
> public Class[] getClassContext() {
>      return classContext;
> }
> which is seen by JaxB at runtime inside Karaf which cause it to marshall
> the Exception in SOAP services with a wrong XML, an XML which include
> <classContext> tags.
>
> The class in Karaf has not changed since committed by Guillaume Nodet in
> 2010, so this issue with CXF has probably always been there.
>
> In my opinion, this getter should be private or protected as I guess it is
> only used on the nested class method's getThrowableContext (it is a
> replacement for the JRE's class, I don't think there are external project
> using this modification of the Exception class).
>
>
> To confirm my thesis, I've hacked the org.apache.karaf.exception-2.4.0.jar
> inside the lib/endorsed folder with a class compiled by myself where I've
> changed the method to
> private Class[] getClassContext() {
>      return classContext;
> }
> and with this hack, Karaf has continued to work (and my CXF service now
> works properly).
>
> Do you think there are potential side effects in this fix?
> Do you need me to open an issue on Jira to handle the problem?
> If it is confirmed that the fix of making this method private, do you think
> it could be included soon on the next Karaf Release?
>
> Thank you very much to all,
> Cristiano
>

-- 
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com