karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From 3cky <...@git.apache.org>
Subject [GitHub] karaf-cellar pull request: Fixed Hazelcast queue consumer exceptio...
Date Fri, 29 May 2015 12:54:09 GMT
GitHub user 3cky opened a pull request:

    https://github.com/apache/karaf-cellar/pull/9

    Fixed Hazelcast queue consumer exceptions handling.

    Current Cellar Hazelcast queue consumer implementation has some problems with exceptions
handling:
    
    - Exceptions in `consume(e)` method are catched outside `while (isConsuming)` loop, so
any exception will break queue consuming;
    -  `HazelcastInstanceNotActiveException`s thrown by `getQueue().poll()` method of queue
consumer while Hazelcast is shutdowning are logged as errors and that's quite noisy.
    
    Proposed patch should fix these problems.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/3cky/karaf-cellar fix-hazelcast-queue-consuming

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf-cellar/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
    
----
commit bbb6c2586d535763817f8458c7a6db4b01ab2e20
Author: Victor Antonovich <v.antonovich@gmail.com>
Date:   2015-05-29T12:28:35Z

    Fixed Hazelcast queue consumer exceptions handling.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message