Mailing-List: contact dev-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Received-SPF: pass (nike.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
Message-ID: <5316DF01.1050309@nanthrax.net>
Date: Wed, 05 Mar 2014 09:23:29 +0100
From: =?ISO-8859-1?Q?Jean-Baptiste_Onofr=E9?= <jb@nanthrax.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Thunderbird/24.3.0
MIME-Version: 1.0
To: dev@karaf.apache.org
Subject: Re: [PROPOSAL] karaf-maven-plugin changes
References: <53161DF1.2070902@nanthrax.net>
 <5316D4D2.2020103@die-schneider.net> <5316D607.4080404@nanthrax.net>
 <5316D8F0.50606@die-schneider.net>
In-Reply-To: <5316D8F0.50606@die-schneider.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable

Rethinking about this, I propose:

groupId: org.apache.karaf.maven.plugins
artifactId: [scr-maven-plugin, instance-maven-plugin,=20
feature-maven-plugin, kar-maven-plugin, ...]

The plugin module will be in each module:

- instance/instance-maven-plugin
- scr/scr-maven-plugin
- features/feature-maven-plugin
- kar/kar-maven-plugin
- ...

With tests/itests in each plugin

The tooling module will disappear.

WDYT ?

Regards
JB

On 03/05/2014 08:57 AM, Christian Schneider wrote:
> I think the big problem with one big plugin project is that the code
> will be very difficult to maintain and test.
> The command names below sound good. Especially that they sound similar
> to karaf commands. So it it easier for users to know what they do.
>
> I think it should be possible to split the plugin into projects based o=
n
> the name before the ":". These goals should do similar things and so
> should have similar
> dependencies and make good candidates for modules.
>
> Christian
>
> On 05.03.2014 08:45, Jean-Baptiste Onofr=E9 wrote:
>> I would prefer to have one plugin with multiple goal (I think it's
>> better for the users).
>>
>> I have no problem to rename/split plugins for future. What do you
>> think about:
>>
>> - karaf-commands:documentation
>> - karaf-scr:scr
>> - karaf-kar:create
>> - karaf-kar:install
>> - karaf-features:populate-repository
>> - karaf-features:generate
>> - karaf-features:validate
>> - karaf-instance:archive
>> - karaf-instance:run
>> - karaf-instance:deploy
>> - karaf-instance:client
>>
>> ?
>>
>> Regards
>> JB
>>
>> On 03/05/2014 08:40 AM, Christian Schneider wrote:
>>> I think we should not put all karaf plugins into one maven plugin.
>>> Instead I think it makes more
>>> sense to analyze which goals have similar dependencies and put them
>>> together.
>>>
>>> For example the karaf-scr plugin has very few dependencies and is bet=
ter
>>> suited to be kept as a separate plugin.
>>> The same may apply for others but I have not looked into them in deta=
il.
>>>
>>> Christian
>>>
>>>
>>> Am 04.03.2014 19:39, schrieb Jean-Baptiste Onofr=E9:
>>>> Hi all,
>>>>
>>>> I would like to discuss with you about my current work on the
>>>> karaf-maven-plugin:
>>>>
>>>> 1/ on master, I refactored the karaf-maven-plugin to use the Maven
>>>> annotations. It's simpler and cleaner, and compatible with all Maven
>>>> version. I also added the Maven 3.1 and 3.2 support. I also fixed th=
e
>>>> same issue as on karaf-3.0.x (see below) and cleanup the code (using
>>>> global
>>>> I propose the following cleanup/refactoring/renaming on the goals:
>>>> - karaf:commands-generate-help renamed to karaf:commands-documentati=
on
>>>> - karaf:create-instance-archive renamed to karaf:instance-archive
>>>> - karaf:features-add-to-repository renamed to karaf:populate-reposit=
ory
>>>> - karaf:features-create-kar renamed to karaf:create-kar
>>>> - karaf:features-export-meta-data renamed to karaf:export-metadata
>>>> - karaf:features-generate-descriptor renames to karaf:create-feature=
s
>>>> - karaf:features-validate-descriptor renamed to karaf:validate-featu=
res
>>>> Introduction of new goals:
>>>> - karaf:client to interact with a running instance
>>>> - karaf:instance to interact with instances (start, stop, etc)
>>>> - karaf:deploy to deploy bundles or features (and eventually populat=
e
>>>> the system repository using scp)
>>>> - karaf:run to bootstrap and run a Karaf container
>>>> I also merged the scr-karaf-maven-plugin in karaf-maven-plugin as a
>>>> dedicated goal (karaf:scr).
>>>> 2/ on karaf-3.0.x branch, I introduced a set of new integration test=
s
>>>> (using the maven-invoker-plugin). I fixed the different issues
>>>> (construct global features set to resolve all features including
>>>> transitive ones, support of file and http URLs, support of
>>>> <configfile/> in features repository XML, etc).
>>>>
>>>> Thoughts ?
>>>>
>>>> Regards
>>>> JB
>>>
>>>
>>
>
>

--=20
Jean-Baptiste Onofr=E9
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com