Mailing-List: contact dev-help@karaf.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@karaf.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <5167B1D4.2030802@nanthrax.net>
Date: Fri, 12 Apr 2013 09:03:48 +0200
From: =?ISO-8859-1?Q?Jean-Baptiste_Onofr=E9?= <jb@nanthrax.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20130329 Thunderbird/17.0.5
MIME-Version: 1.0
To: dev@karaf.apache.org
Subject: Re: Warning when files are not deployed by a feature
References: <5166B780.8030201@die-schneider.net>
In-Reply-To: <5166B780.8030201@die-schneider.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable

Hi Christian,

We have an option "overwrite" to define if the file should be=20
overwritten or not during feature installation.

I'm agree with you, we should log a warn message to inform the user if a=20
configfile or config (resulting to a file) don't overwrite the final file=
.

For the -f, I'm not sure: overriding the option in the features XML=20
could be risky, but basicly, it's the user responsibility.

It sounds good to me.

Do you want that I create the Jira about that ?

Regards
JB

On 04/11/2013 03:15 PM, Christian Schneider wrote:
> Hi all,
>
> karaf can deploy files like config files during the installation of a
> feature. If the file is already present then it is not overwritten.
> I wonder if we should print a warning in this case. One use case for
> this is a new version of a feature that adds a new needed property
> to a config file. If the old feature was already present then the old
> config will be present and the user may also have done changes.
>
> So there might be cases where a feature works if it can install its
> default configs but does not work when they are already present but
> invalid.
> So we could write for each file that is already present:
> "Warning: file <path> to be deployed is already present and will not be
> changed."
>
> We could also provide an option in feature:install like -f that forces
> all files to be overwritten if someone wants to make sure the feature
> installation should use the defaults.
>
> What do you think?
>
> Christian
>

--=20
Jean-Baptiste Onofr=E9
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com