karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Baptiste Onofré ...@nanthrax.net>
Subject Re: Warning when files are not deployed by a feature
Date Fri, 12 Apr 2013 07:36:38 GMT
Awesome,

thanks a lot Christian

Regards
JB

On 04/12/2013 09:29 AM, Christian Schneider wrote:
> I created the issue as https://issues.apache.org/jira/browse/KARAF-2266.
>
> Christian
>
> On 12.04.2013 09:03, Jean-Baptiste Onofré wrote:
>> Hi Christian,
>>
>> We have an option "overwrite" to define if the file should be
>> overwritten or not during feature installation.
>>
>> I'm agree with you, we should log a warn message to inform the user if
>> a configfile or config (resulting to a file) don't overwrite the final
>> file.
>>
>> For the -f, I'm not sure: overriding the option in the features XML
>> could be risky, but basicly, it's the user responsibility.
>>
>> It sounds good to me.
>>
>> Do you want that I create the Jira about that ?
>>
>> Regards
>> JB
>>
>> On 04/11/2013 03:15 PM, Christian Schneider wrote:
>>> Hi all,
>>>
>>> karaf can deploy files like config files during the installation of a
>>> feature. If the file is already present then it is not overwritten.
>>> I wonder if we should print a warning in this case. One use case for
>>> this is a new version of a feature that adds a new needed property
>>> to a config file. If the old feature was already present then the old
>>> config will be present and the user may also have done changes.
>>>
>>> So there might be cases where a feature works if it can install its
>>> default configs but does not work when they are already present but
>>> invalid.
>>> So we could write for each file that is already present:
>>> "Warning: file <path> to be deployed is already present and will not be
>>> changed."
>>>
>>> We could also provide an option in feature:install like -f that forces
>>> all files to be overwritten if someone wants to make sure the feature
>>> installation should use the defaults.
>>>
>>> What do you think?
>>>
>>> Christian
>>>
>>
>
>

-- 
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Mime
View raw message