karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christian Schneider <ch...@die-schneider.net>
Subject Re: [Discuss] Logging when starting features
Date Tue, 02 Oct 2012 09:17:56 GMT
Yes .. that is mostly what I meant.

I would rather print the feature log message on success as I think it is 
more interesting when the feature is installed than when it starts 
installing.
LOGGER.info("Feature ... installed");

I also agree about logging the installed and already installed bundles.

Christian

On 10/02/2012 11:05 AM, Guillaume Nodet wrote:
> I suppose you mean the 'installed' features ?
> So changing
>    LOGGER.debug("Installing feature ..."
> to
>    LOGGER.info("Installing feature ..."
>
> and
>
>      LOGGER.info("Starting bundle: {}", b.getSymbolicName());
> to
>      LOGGER.debug("Starting bundle: {}", b.getSymbolicName());
>
> If so, that makes sense to me.
> Btw, I think we should also log at debug level installed and already
> installed bundles inside doInstallFeature(), so in addition to the
> System.out.println(), also log the same messages at debug level.
>
>
> On Tue, Oct 2, 2012 at 10:52 AM, Christian Schneider <
> chris@die-schneider.net> wrote:
>
>> In the FeatureService we currently log a line on info level for each
>> bundle started. We do not log the starting features though.
>>
>> So I propose to log the starting of bundles only on debug level and
>> instead log the started features on info level. So we have a more coarse
>> grained feedback what happens.
>>
>> What do you think?
>>
>> Christian
>>
>
>


Mime
View raw message