karaf-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jamie G." <jamie.goody...@gmail.com>
Subject Re: svn commit: r1372333 - in /karaf/trunk: main/src/main/java/org/apache/karaf/main/ shell/console/src/main/java/org/apache/karaf/shell/console/impl/jline/
Date Fri, 17 Aug 2012 13:06:21 GMT
Christian updated the code with an additional commit(s) to correct the
behaviour, thus removing the need for my -1.

Cheers,
Jamie

On Fri, Aug 17, 2012 at 4:40 AM, Christian Schneider
<chris@die-schneider.net> wrote:
> I corrected the commit as soon as Jamie informed me of the problem. The
> default is now to not have the delayed console as a default. Btw. a -1 was
> not really necessary. A simple mail to let me know would have done.
> My goal was to turn off the delayed start by default as I stated in our
> discussion. That it did not work in my first commit was only an error that I
> of course fixed. I only wondered in my first reaction as I was so sure I
> tested it well.
>
> Btw. reverting the commit would have removed the option completely and the
> console delay could not be turned off at all.
>
> Christian
>
> Am 17.08.2012 06:41, schrieb Andreas Pieber:
>
>> well, we can't release 3.x as long as there are any commits with -1
>> votes on them --> we either need to revert this commit or add some
>> extensions. I just don't want to let this lay around suppressing any
>> 3.x releases...
>>
>> Kind regards,
>> Andreas
>>
>
> --
>  Christian Schneider
> http://www.liquid-reality.de
>
> Open Source Architect
> Talend Application Integration Division http://www.talend.com
>

Mime
View raw message