Return-Path: X-Original-To: apmail-karaf-dev-archive@minotaur.apache.org Delivered-To: apmail-karaf-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 590229B6B for ; Mon, 26 Mar 2012 03:58:34 +0000 (UTC) Received: (qmail 31492 invoked by uid 500); 26 Mar 2012 03:58:34 -0000 Delivered-To: apmail-karaf-dev-archive@karaf.apache.org Received: (qmail 31402 invoked by uid 500); 26 Mar 2012 03:58:31 -0000 Mailing-List: contact dev-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list dev@karaf.apache.org Received: (qmail 31374 invoked by uid 99); 26 Mar 2012 03:58:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Mar 2012 03:58:30 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of anpieber@gmail.com designates 209.85.210.176 as permitted sender) Received: from [209.85.210.176] (HELO mail-iy0-f176.google.com) (209.85.210.176) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Mar 2012 03:58:22 +0000 Received: by iagw33 with SMTP id w33so10288468iag.21 for ; Sun, 25 Mar 2012 20:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=zBnU+QKIXnHMCM71mbVyW79B/qcP3a6miHFCLr2zvl8=; b=f47UU65miAsxQ6VlbJSP3o3cx30IlZ/NRvPPDw7noQYiZY+Ac21s2yn11ut+6+cxmW lk+9FCmTKu9CHk7HkHT81TRuqO/sE5NXejwjI5iBLHSj5xITT5l5wtjxMT9eXj1xNay9 J2lKO0/SYDnKuAM0ln73xIcfFCSckYSM6sfXp597jpxPBGP0b6f19iTvY29VxypALfPp tdQz+X0v61k54RFu0Kf46COZP0Xwhwxr459d4/8wr0NWUULlRa22JPfJRbSHDA9CNVZ7 SPlA9adr9Pt/l8VPo9ALT/LmTxYYHThsxmfYwEaqsA3hVXZ+fqskxxIy1YW7V1mlB4MW Ggxw== MIME-Version: 1.0 Received: by 10.43.134.199 with SMTP id id7mr11805580icc.21.1332734280939; Sun, 25 Mar 2012 20:58:00 -0700 (PDT) Received: by 10.50.188.200 with HTTP; Sun, 25 Mar 2012 20:58:00 -0700 (PDT) Date: Mon, 26 Mar 2012 05:58:00 +0200 Message-ID: Subject: Re: svn commit: r1303843 - in /karaf/branches/karaf-2.2.x: management/mbeans/config/src/main/java/org/apache/karaf/management/mbeans/config/internal/ConfigMBeanImpl.java shell/config/src/main/java/org/apache/karaf/shell/config/ConfigCommandSupport.ja From: Andreas Pieber To: dev@karaf.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable maybe it's a good idea to log the real exception first? Otherwise we'll use the stacktrace of the original exception if only giving the message to the IO exception. Kind regards, Andreas On Thu, Mar 22, 2012 at 16:38, wrote: > Author: jgoodyear > Date: Thu Mar 22 15:38:38 2012 > New Revision: 1303843 > > URL: http://svn.apache.org/viewvc?rev=3D1303843&view=3Drev > Log: > [KARAF-1279] IOExceptions used in an incompatible way with Java 5. > > Changing IOException call to IOException(String) signature. > > > Modified: > =A0 =A0karaf/branches/karaf-2.2.x/management/mbeans/config/src/main/java/= org/apache/karaf/management/mbeans/config/internal/ConfigMBeanImpl.java > =A0 =A0karaf/branches/karaf-2.2.x/shell/config/src/main/java/org/apache/k= araf/shell/config/ConfigCommandSupport.java > > Modified: karaf/branches/karaf-2.2.x/management/mbeans/config/src/main/ja= va/org/apache/karaf/management/mbeans/config/internal/ConfigMBeanImpl.java > URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/management/m= beans/config/src/main/java/org/apache/karaf/management/mbeans/config/intern= al/ConfigMBeanImpl.java?rev=3D1303843&r1=3D1303842&r2=3D1303843&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- karaf/branches/karaf-2.2.x/management/mbeans/config/src/main/java/org= /apache/karaf/management/mbeans/config/internal/ConfigMBeanImpl.java (origi= nal) > +++ karaf/branches/karaf-2.2.x/management/mbeans/config/src/main/java/org= /apache/karaf/management/mbeans/config/internal/ConfigMBeanImpl.java Thu Ma= r 22 15:38:38 2012 > @@ -187,7 +187,7 @@ public class ConfigMBeanImpl extends Sta > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 storageFile =3D new File(= new URL((String) val).toURI()); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 } > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 } catch (Exception e) { > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0throw new IOException(e); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0throw new IOException(e.getMessa= ge()); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 } > =A0 =A0 =A0 =A0 =A0 =A0 } > =A0 =A0 =A0 =A0 =A0 =A0 Properties p =3D new Properties(storageFile); > > Modified: karaf/branches/karaf-2.2.x/shell/config/src/main/java/org/apach= e/karaf/shell/config/ConfigCommandSupport.java > URL: http://svn.apache.org/viewvc/karaf/branches/karaf-2.2.x/shell/config= /src/main/java/org/apache/karaf/shell/config/ConfigCommandSupport.java?rev= =3D1303843&r1=3D1303842&r2=3D1303843&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- karaf/branches/karaf-2.2.x/shell/config/src/main/java/org/apache/kara= f/shell/config/ConfigCommandSupport.java (original) > +++ karaf/branches/karaf-2.2.x/shell/config/src/main/java/org/apache/kara= f/shell/config/ConfigCommandSupport.java Thu Mar 22 15:38:38 2012 > @@ -162,7 +162,7 @@ public abstract class ConfigCommandSuppo > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 storageFile =3D new File(new URL((String)= val).toURI()); > =A0 =A0 =A0 =A0 =A0 =A0 } > =A0 =A0 =A0 =A0 =A0 =A0 } catch (Exception e) { > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0throw new IOException(e); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0throw new IOException(e.getMessage()); > =A0 =A0 =A0 =A0 =A0 =A0 } > =A0 =A0 =A0 =A0 } > =A0 =A0 =A0 =A0 Properties p =3D new Properties(storageFile); > >