Return-Path: 
 <dev-return-123-apmail-karaf-dev-archive=karaf.apache.org@karaf.apache.org>
Delivered-To: apmail-karaf-dev-archive@minotaur.apache.org
Received: (qmail 21901 invoked from network); 16 Jul 2010 12:11:45 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 16 Jul 2010 12:11:45 -0000
Received: (qmail 56351 invoked by uid 500); 16 Jul 2010 12:11:45 -0000
Delivered-To: apmail-karaf-dev-archive@karaf.apache.org
Received: (qmail 56309 invoked by uid 500); 16 Jul 2010 12:11:44 -0000
Mailing-List: contact dev-help@karaf.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@karaf.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@karaf.apache.org>
List-Post: <mailto:dev@karaf.apache.org>
List-Id: <dev.karaf.apache.org>
Reply-To: dev@karaf.apache.org
Delivered-To: mailing list dev@karaf.apache.org
Received: (qmail 56301 invoked by uid 99); 16 Jul 2010 12:11:43 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Jul 2010 12:11:43 +0000
X-ASF-Spam-Status: No, hits=2.2 required=10.0
	tests=FREEMAIL_FROM,HTML_MESSAGE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of cmoulliard@gmail.com designates
 74.125.82.176 as permitted sender)
Received: from [74.125.82.176] (HELO mail-wy0-f176.google.com) (74.125.82.176)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Jul 2010 12:11:38 +0000
Received: by wyb29 with SMTP id 29so1831810wyb.21
        for <dev@karaf.apache.org>; Fri, 16 Jul 2010 05:11:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:received:in-reply-to
         :references:date:message-id:subject:from:to:content-type;
        bh=BdrtfAgJTaS+ZtA0+0iCjdfT6gO2S8P0wfpWFjGE2B8=;
        b=YY98fitsuk6Udzq93VuXHFgV+HiXOvSTWtS1ApBvmoMmg+GkDFzZ+3kVdgl3ioiMyw
         KEE7whUCsrkb6VT9Eh31uYnsL7uGKzz/ii3TEDmG6qrp6eSCMqR1yawb5W/ooTygKhlX
         hv0XlCsBkToN0i74o7mxFjR6ASSoAaMxO4psw=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=n095x8YKe/MW0+4oB0nzokClAg/DQXV/zgB/pXFPN8ruZKcanwDJ2Ee7VIf3aSo7QZ
         W0S5xc3fVHNzx6DjPot/TeP3Xmjynq9uwJSGhX3zdKlBaFenJMId1mNIpvaMTX/kvFJZ
         tYHeTCWAxjRopdt8/IZqGyN2uOOovfp9sRQGg=
MIME-Version: 1.0
Received: by 10.227.147.213 with SMTP id m21mr855371wbv.97.1279282277559;
 Fri,
	16 Jul 2010 05:11:17 -0700 (PDT)
Received: by 10.216.91.21 with HTTP; Fri, 16 Jul 2010 05:11:17 -0700 (PDT)
In-Reply-To: <AANLkTikA5vVHnjmrmuVGpEvwq2UlU8P6IjQeDLyXYXKw@mail.gmail.com>
References: <AANLkTikxs_9MnX86JUyC9PW3KKq61__Lrc2qWFr37xgY@mail.gmail.com>
	<AANLkTikA5vVHnjmrmuVGpEvwq2UlU8P6IjQeDLyXYXKw@mail.gmail.com>
Date: Fri, 16 Jul 2010 14:11:17 +0200
Message-ID: <AANLkTikX945QrAuiL6nLXUqnbPD3VxuMSIZNjYV3jLRl@mail.gmail.com>
Subject: Re: Issue in the code - help requested
From: Charles Moulliard <cmoulliard@gmail.com>
To: dev@karaf.apache.org
Content-Type: multipart/alternative; boundary=001485f875d2b8ad56048b801d3a
X-Virus-Checked: Checked by ClamAV on apache.org

--001485f875d2b8ad56048b801d3a
Content-Type: text/plain; charset=ISO-8859-1

I'm sure. I will send you two png files on your email address.

On Fri, Jul 16, 2010 at 1:53 PM, Guillaume Nodet <gnodet@gmail.com> wrote:

> Are you sure they aren't added to the map ? I don't see how that could not
> work.
>
> On Fri, Jul 16, 2010 at 11:02, Charles Moulliard <cmoulliard@gmail.com>
> wrote:
> > Hi,
> >
> > In debug mode, I see that something is wrong in my code :
> >
> > public class FeaturesServiceImpl implements FeaturesService {
> > ...
> >
> >    protected static class InstallationState {
> >        final Set<Bundle> installed = new HashSet<Bundle>();
> >        final List<Bundle> bundles = new ArrayList<Bundle>();
> >        final Map<Long, BundleInfo> bundleInfos = new HashMap<Long,
> > BundleInfo>();
> >        final Map<Feature, Set<Long>> features = new HashMap<Feature,
> > Set<Long>>();
> >    }
> >
> >   protected void doInstallFeature(InstallationState state, Feature
> feature)
> > throws Exception {
> > ...
> >        Set<Long> bundles = new TreeSet<Long>();
> >        for (BundleInfo bInfo : resolve(feature)) {
> >            Bundle b = installBundleIfNeeded(state, bInfo);
> >            bundles.add(b.getBundleId());
> >            state.bundleInfos.put(b.getBundleId(), bInfo);
> >        }
> >        state.features.put(feature, bundles);
> >    }
> >
> >    public void installFeatures(Set<Feature> features, EnumSet<Option>
> > options) throws Exception {
> >        InstallationState state = new InstallationState();
> >        InstallationState failure = new InstallationState();
> >        try {
> >            // Install everything
> >            for (Feature f : features) {
> >                InstallationState s = new InstallationState();
> >                try {
> >                    doInstallFeature(s, f);
> >                     state.bundles.addAll(s.bundles); // Ok --> ArrayList
> of
> > BundleImpl is well copied in state.bundles
> >                     state.bundleInfos.putAll(s.bundleInfos); // NOK -->
> > HashMap of s.bundleInfos is not copied to state.bundleInfos and
> > s.bundleInfos contains well in the HashMap BundleInfo objects
> >                     ...
> >                } catch (Exception e) {
> >
> > What is wrong in the java code (the fact that we use a HashMap defined in
> > InstallationState to copy it from object s to object state, ...) ?
> >
> > Help is welcome ?
> >
> > Kind regards,
> >
> >
> > Charles Moulliard
> >
> > Senior Enterprise Architect (J2EE, .NET, SOA)
> > Apache Camel - ServiceMix Committer
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > Blog : http://cmoulliard.blogspot.com |  Twitter :
> > http://twitter.com/cmoulliard
> > Linkedin : http://www.linkedin.com/in/charlesmoulliard | Skype:
> cmoulliard
> >
>
>
>
> --
> Cheers,
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> Open Source SOA
> http://fusesource.com
>

--001485f875d2b8ad56048b801d3a--