Return-Path: X-Original-To: apmail-karaf-commits-archive@minotaur.apache.org Delivered-To: apmail-karaf-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 220FD17BED for ; Mon, 13 Apr 2015 11:31:28 +0000 (UTC) Received: (qmail 851 invoked by uid 500); 13 Apr 2015 11:31:28 -0000 Delivered-To: apmail-karaf-commits-archive@karaf.apache.org Received: (qmail 824 invoked by uid 500); 13 Apr 2015 11:31:28 -0000 Mailing-List: contact commits-help@karaf.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@karaf.apache.org Delivered-To: mailing list commits@karaf.apache.org Received: (qmail 814 invoked by uid 99); 13 Apr 2015 11:31:28 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Apr 2015 11:31:28 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E2429DFF79; Mon, 13 Apr 2015 11:31:27 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: jbonofre@apache.org To: commits@karaf.apache.org Message-Id: <48c76b81852544e0ab9088d293942f51@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: karaf git commit: [KARAF-3660] Setting JMX SSL causes StringIndexOutOfBoundsException when setting keyPasswords without = symbol Date: Mon, 13 Apr 2015 11:31:27 +0000 (UTC) Repository: karaf Updated Branches: refs/heads/karaf-2.x 672d6a949 -> 9da4d6ae4 [KARAF-3660] Setting JMX SSL causes StringIndexOutOfBoundsException when setting keyPasswords without = symbol Project: http://git-wip-us.apache.org/repos/asf/karaf/repo Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/9da4d6ae Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/9da4d6ae Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/9da4d6ae Branch: refs/heads/karaf-2.x Commit: 9da4d6ae41345ad5b51c0fa8ccbf7b05135a6dee Parents: 672d6a9 Author: Jay SenSharma Authored: Sun Apr 12 16:04:45 2015 +0530 Committer: Jean-Baptiste Onofré Committed: Mon Apr 13 12:57:02 2015 +0200 ---------------------------------------------------------------------- .../apache/karaf/jaas/config/impl/ResourceKeystoreInstance.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/karaf/blob/9da4d6ae/jaas/config/src/main/java/org/apache/karaf/jaas/config/impl/ResourceKeystoreInstance.java ---------------------------------------------------------------------- diff --git a/jaas/config/src/main/java/org/apache/karaf/jaas/config/impl/ResourceKeystoreInstance.java b/jaas/config/src/main/java/org/apache/karaf/jaas/config/impl/ResourceKeystoreInstance.java index f2c7260..9ced5fa 100644 --- a/jaas/config/src/main/java/org/apache/karaf/jaas/config/impl/ResourceKeystoreInstance.java +++ b/jaas/config/src/main/java/org/apache/karaf/jaas/config/impl/ResourceKeystoreInstance.java @@ -130,7 +130,9 @@ public class ResourceKeystoreInstance implements KeystoreInstance { for (int i = 0; i < keys.length; i++) { String key = keys[i]; int pos = key.indexOf('='); - this.keyPasswords.put(key.substring(0, pos), key.substring(pos + 1).toCharArray()); + if (pos > 0) { + this.keyPasswords.put(key.substring(0, pos), key.substring(pos + 1).toCharArray()); + } } } }