karaf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jbono...@apache.org
Subject svn commit: r1538983 - in /karaf/trunk/system: command/src/main/java/org/apache/karaf/system/commands/SystemProperty.java core/src/main/java/org/apache/karaf/system/management/internal/System.java
Date Tue, 05 Nov 2013 13:15:16 GMT
Author: jbonofre
Date: Tue Nov  5 13:15:15 2013
New Revision: 1538983

URL: http://svn.apache.org/r1538983
Log:
[KARAF-2474] Cleanup comments and help in system:property command and SystemMBean

Modified:
    karaf/trunk/system/command/src/main/java/org/apache/karaf/system/commands/SystemProperty.java
    karaf/trunk/system/core/src/main/java/org/apache/karaf/system/management/internal/System.java

Modified: karaf/trunk/system/command/src/main/java/org/apache/karaf/system/commands/SystemProperty.java
URL: http://svn.apache.org/viewvc/karaf/trunk/system/command/src/main/java/org/apache/karaf/system/commands/SystemProperty.java?rev=1538983&r1=1538982&r2=1538983&view=diff
==============================================================================
--- karaf/trunk/system/command/src/main/java/org/apache/karaf/system/commands/SystemProperty.java
(original)
+++ karaf/trunk/system/command/src/main/java/org/apache/karaf/system/commands/SystemProperty.java
Tue Nov  5 13:15:15 2013
@@ -36,7 +36,7 @@ public class SystemProperty extends Abst
     @Option(name = "-p", aliases = {"--persistent"}, description = "Persist the new value
to the etc/system.properties file")
     boolean persistent;
 
-    @Option(name = "-f", aliases = {"--file-dump"}, description = "Dump all system properties
in a file")
+    @Option(name = "-f", aliases = {"--file-dump"}, description = "Dump all system properties
in a file (in data folder)")
     boolean dumpToFile;
 
     @Option(name = "-u", aliases = {"--unset"}, description = "Show unset know properties
with value unset")
@@ -100,13 +100,12 @@ public class SystemProperty extends Abst
                                 "dump-properties-" + System.currentTimeMillis() + ".properties"
                         )
                 );
-                ps.println("#Dump of the System and OSGi properties with the command dev:dump-properties");
-                ps.println("#Dump execute at " + new SimpleDateFormat().format(new Date()));
+                ps.println("#Dump of the System and OSGi properties with the command system:property");
+                ps.println("#Dump executed at " + new SimpleDateFormat().format(new Date()));
                 printOrderedProperties(props, ps);
                 ps.flush();
                 ps.close();
             } else {
-                System.out.println("Dumping OSGi and System properties");
                 printOrderedProperties(props, System.out);
             }
 

Modified: karaf/trunk/system/core/src/main/java/org/apache/karaf/system/management/internal/System.java
URL: http://svn.apache.org/viewvc/karaf/trunk/system/core/src/main/java/org/apache/karaf/system/management/internal/System.java?rev=1538983&r1=1538982&r2=1538983&view=diff
==============================================================================
--- karaf/trunk/system/core/src/main/java/org/apache/karaf/system/management/internal/System.java
(original)
+++ karaf/trunk/system/core/src/main/java/org/apache/karaf/system/management/internal/System.java
Tue Nov  5 13:15:15 2013
@@ -160,8 +160,8 @@ public class System extends StandardMBea
 
         if (dumpToFile) {
             PrintStream ps = new PrintStream(new File(bundleContext.getProperty("karaf.data"),
"dump-properties-" + java.lang.System.currentTimeMillis() + ".properties"));
-            ps.println("#Dump of the System and OSGi properties with the command dev:dump-properties");
-            ps.println("#Dump execute at " + new SimpleDateFormat().format(new Date()));
+            ps.println("#Dump of the System and OSGi properties");
+            ps.println("#Dump executed at " + new SimpleDateFormat().format(new Date()));
             printOrderedProperties(props, ps);
             ps.flush();
             ps.close();



Mime
View raw message