kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guozhang Wang (Jira)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-13248) Class name mismatch for LoggerFactory.getLogger method in TimeOrderedWindowStoreBuilder.java
Date Tue, 07 Sep 2021 16:34:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-13248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411347#comment-17411347
] 

Guozhang Wang commented on KAFKA-13248:
---------------------------------------

[~sider-bughunter] Thanks for the find. I'm currently working on KAFKA-13216 in which I've
used a kv-store instead of a window store, and hence I've renamed the whole class as well.
Do you mind if I just incorporate your findings in the other PR?

> Class name mismatch for LoggerFactory.getLogger method in TimeOrderedWindowStoreBuilder.java
> --------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-13248
>                 URL: https://issues.apache.org/jira/browse/KAFKA-13248
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: S. B. Hunter
>            Priority: Minor
>         Attachments: KAFKA-13248.1.patch
>
>
> I have noticed a mismatch with the class name passed to the LoggerFactory.getLogger method.
This would make it hard to track the source of log messages.
> public class {color:#00875a}TimeOrderedWindowStoreBuilder{color}<K, V> extends
AbstractStoreBuilder<K, V, WindowStore<K, V>> {
>  private final Logger log = LoggerFactory.getLogger({color:#de350b}WindowStoreBuilder{color}.class);
> private final WindowBytesStoreSupplier storeSupplier;
> public {color:#00875a}TimeOrderedWindowStoreBuilder{color}(final WindowBytesStoreSupplier
storeSupplier,
>  final Serde<K> keySerde,



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message