kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kafka] showuon edited a comment on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config
Date Sun, 11 Jul 2021 03:51:49 GMT

showuon edited a comment on pull request #10811:
URL: https://github.com/apache/kafka/pull/10811#issuecomment-877736694


   @rondagostino , thanks for comments and many good catch! I've updated the PR. 
   
   > The PR as currently written restricts describing configs via --zookeeper to user and
broker configs. Unlike with altering, it does not perform a check to see if the broker is
not started. Do we wish to add such a check?
   
   Good suggestion! Make sense to me. I added the check for broker type describe via `--zookeeper`,
and add tests. 
   
   Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message