kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kafka] mjsax commented on a change in pull request #10640: KAFKA-10847: Set StreamsConfig on InternalTopologyDriver before writing topology
Date Thu, 06 May 2021 19:00:08 GMT

mjsax commented on a change in pull request #10640:
URL: https://github.com/apache/kafka/pull/10640#discussion_r627687839



##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java
##########
@@ -98,12 +108,19 @@ public void writeToTopology(final InternalTopologyBuilder topologyBuilder)
{
         topologyBuilder.addStateStore(thisWindowStoreBuilder, thisWindowedStreamProcessorName,
otherProcessorName);
         topologyBuilder.addStateStore(otherWindowStoreBuilder, otherWindowedStreamProcessorName,
thisProcessorName);
 
-        final StreamsConfig streamsConfig = topologyBuilder.getStreamsConfig();
-        if (streamsConfig == null || StreamsConfig.InternalConfig.getBoolean(streamsConfig.originals(),
ENABLE_KSTREAMS_OUTER_JOIN_SPURIOUS_RESULTS_FIX, true)) {
+        if (props == null || StreamsConfig.InternalConfig.getBoolean(toMap(props), ENABLE_KSTREAMS_OUTER_JOIN_SPURIOUS_RESULTS_FIX,
true)) {

Review comment:
       This works (note that `Properties implements Map<Object, Object>)`:
   ```
   Properties p = new Properties();
   Map<String, Object> foo = new HashMap(p);
   ```
   
   So you should be able to do `getBoolean(new HashMap(props), ...)` (Need to omit the generics
though...)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message