kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kafka] C0urante commented on pull request #10605: KAFKA-12726 prevent a stuck Task.stop() from blocking subsequent Task.stops()s
Date Thu, 29 Apr 2021 11:49:12 GMT

C0urante commented on pull request #10605:
URL: https://github.com/apache/kafka/pull/10605#issuecomment-829162686


   Thanks for the ping @tombentley and thanks for the PR @ryannedolan! I've left a more thorough
summary of my thoughts on the ticket as I'm not sure a PR is required at all at this point.
   
   Looking at the changes here, I suspect this may be due to a conflation of `WorkerTask::stop`
with `Task::stop` at [this line](https://github.com/apache/kafka/blob/f9de25f046452b2a6d916e6bca41e31d49bbdecf/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java#L842).
It's a mistake I've personally made in the past a few times as well; if this turns out to
be the source of confusion here, we might consider just changing the name of `WorkerTask::stop`
to something else or even just removing it entirely and replacing usage with the existing
`WorkerTask::triggerStop` method to save other readers of the code base time and effort in
the future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message