kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kafka] chia7712 commented on a change in pull request #10496: MINOR: move NoOpSnapshotWriter to main
Date Wed, 07 Apr 2021 05:05:15 GMT

chia7712 commented on a change in pull request #10496:
URL: https://github.com/apache/kafka/pull/10496#discussion_r608341991



##########
File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##########
@@ -208,8 +208,7 @@ public QuorumController build() throws Exception {
                     "org.apache.kafka.controller.MockControllerMetrics").getConstructor().newInstance();

Review comment:
       Is this a potential issue? `"org.apache.kafka.controller.MockControllerMetrics"` is
not in produce code also.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message