From jira-return-58929-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Wed Dec 9 15:19:00 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 4C2B718037A for ; Wed, 9 Dec 2020 16:19:00 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id DD3C7677B4 for ; Wed, 9 Dec 2020 15:18:58 +0000 (UTC) Received: (qmail 10679 invoked by uid 500); 9 Dec 2020 15:18:58 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 10667 invoked by uid 99); 9 Dec 2020 15:18:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Dec 2020 15:18:58 +0000 From: =?utf-8?q?GitBox?= To: jira@kafka.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bkafka=5D_ijuma_commented_on_a_change_in_pull_reque?= =?utf-8?q?st_=239694=3A_MINOR=3A_Change_the_input_type_of_DescribeAclsRespo?= =?utf-8?q?nse=23aclsResources_from_Collection_to_Iterable_to_avoid_creating?= =?utf-8?q?_useless_collection?= Message-ID: <160752713805.15632.8399017711932015757.asfpy@gitbox.apache.org> Date: Wed, 09 Dec 2020 15:18:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: ijuma commented on a change in pull request #9694: URL: https://github.com/apache/kafka/pull/9694#discussion_r539394353 ########## File path: core/src/main/scala/kafka/server/KafkaApis.scala ########## @@ -2509,12 +2509,10 @@ class KafkaApis(val requestChannel: RequestChannel, .setThrottleTimeMs(requestThrottleMs))) case Some(auth) => val filter = describeAclsRequest.filter - val returnedAcls = new util.HashSet[AclBinding]() - auth.acls(filter).forEach(returnedAcls.add) Review comment: Note that this means we no longer filter duplicates. We should make sure that doesn't cause issues. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org