kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kafka] gharris1727 commented on pull request #9765: KAFKA-10763: Fix incomplete cooperative rebalances preventing connector/task revocations
Date Fri, 18 Dec 2020 04:41:30 GMT

gharris1727 commented on pull request #9765:
URL: https://github.com/apache/kafka/pull/9765#issuecomment-747863472


   Note: as-is, this PR does not reproduce the exact exceptions noted in the JIRA, as the
Worker is mocked out for this test. I believe that it's sufficient to show that without this
fix, the DistributedHerder::onRevoked does not stop the tasks. This assumes that if we don't
stop the task in the Worker (and the task does not fail), that a subsequent task-start would
cause the Worker to throw the exception found in the JIRA.
   
   cc @C0urante @ncliang PTAL, thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message