kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic
Date Fri, 11 Dec 2020 05:43:46 GMT

d8tltanc commented on a change in pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#discussion_r540705023



##########
File path: core/src/test/scala/unit/kafka/security/authorizer/AclAuthorizerTest.scala
##########
@@ -100,8 +106,15 @@ class AclAuthorizerTest extends ZooKeeperTestHarness {
 
   @After
   override def tearDown(): Unit = {
-    aclAuthorizer.close()
-    aclAuthorizer2.close()
+    val authorizers = Seq(aclAuthorizer, aclAuthorizer2)
+    authorizers.foreach(a => {
+      a.acls(AclBindingFilter.ANY).forEach(bd => {
+        removeAcls(aclAuthorizer, Set(bd.entry), bd.pattern())

Review comment:
       Otherwise "deny all" will remain in ZK during the whole test process since ZK won't
be restarted or re-instantiated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message