kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kafka] gardnervickers commented on a change in pull request #9601: KAFKA-10729: Bump remaining RPC's to use tagged fields.
Date Sun, 29 Nov 2020 18:45:14 GMT

gardnervickers commented on a change in pull request #9601:
URL: https://github.com/apache/kafka/pull/9601#discussion_r532249311



##########
File path: clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java
##########
@@ -613,12 +613,12 @@ private void sendResponse(ResponseHeader respHeader, Struct response)
{
         selector.completeReceive(new NetworkReceive(node.idString(), buffer));
     }
 
-    private void sendThrottledProduceResponse(int correlationId, int throttleMs) {
+    private void sendThrottledProduceResponse(int correlationId, int throttleMs, short version)
{

Review comment:
       This is to fix `testThrottlingNotEnabledForConnectionToOlderBroker`. The test forces
ApiVersionsResponse to version 5, but relied on the fact that nothing really changed between
version 5 and version 8 for PRODUCE responses. With flex versions we need to ensure the response
matches the ApiVersions response




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message