kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kafka] jsancio commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage
Date Wed, 25 Nov 2020 17:26:03 GMT

jsancio commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r530537291



##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -370,14 +370,23 @@ private void onBecomeLeader(long currentTimeMs) {
         );
     }
 
+    private List<Voter> getVotersFromVoterId(Set<Integer> voterIds) {

Review comment:
       Just a nitpick. It doesn't need to be a object method as it doesn't use any of the
instance fields. When reading and maintaining a lot of code it is good to know that a method
doesn't use instance fields.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message