kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kafka] wcarlson5 commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler
Date Fri, 06 Nov 2020 16:08:19 GMT

wcarlson5 commented on a change in pull request #9487:
URL: https://github.com/apache/kafka/pull/9487#discussion_r518850419



##########
File path: streams/src/main/resources/common/message/SubscriptionInfoData.json
##########
@@ -57,6 +57,11 @@
       "name": "uniqueField",
       "versions": "8+",
       "type": "int8"
+    },
+    {
+      "name": "shutdownRequested",
+      "versions": "9+",
+      "type": "int8"

Review comment:
       I think I agree on the name, I am not sure about the type. We should be able to fit
thousands of different error code into the byte so we should not run out of space. The reason
the errorCode. is an integer in the first place is because there is not `AtomicByte` that
I know of.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message