kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [kafka] dengziming commented on a change in pull request #9571: KAFKA-10691: AlterIsr Respond with wrong Error Id
Date Fri, 06 Nov 2020 06:54:13 GMT

dengziming commented on a change in pull request #9571:
URL: https://github.com/apache/kafka/pull/9571#discussion_r518554842



##########
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##########
@@ -2261,7 +2261,7 @@ class KafkaController(val config: KafkaConfig,
     val brokerEpochOpt = controllerContext.liveBrokerIdAndEpochs.get(brokerId)
     if (brokerEpochOpt.isEmpty) {
       info(s"Ignoring AlterIsr due to unknown broker $brokerId")
-      callback.apply(Right(Errors.STALE_BROKER_EPOCH))
+      callback.apply(Right(Errors.UNKNOWN_MEMBER_ID))

Review comment:
       Thank you for your reply,  here we have 2 judgement. the first is `if (brokerEpochOpt.isEmpty)`
and second is `if(!brokerEpochOpt.contains(brokerEpoch))`, they both return `STALE_BROKER_EPOCH
`. maybe the first is meant to return`UNKNOWN_MEMBER_ID `.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message