kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Roesler (Jira)" <j...@apache.org>
Subject [jira] [Created] (KAFKA-10628) Follow-up: Remove all unnecessary dummy TopologyTestDriver configs
Date Thu, 22 Oct 2020 14:24:00 GMT
John Roesler created KAFKA-10628:

             Summary: Follow-up: Remove all unnecessary dummy TopologyTestDriver configs
                 Key: KAFKA-10628
                 URL: https://issues.apache.org/jira/browse/KAFKA-10628
             Project: Kafka
          Issue Type: Task
            Reporter: John Roesler

After [https://github.com/apache/kafka/pull/9477,] we no longer need to specify dummy values
for bootstrap servers and application id when creating a TopologyTestDriver.


This task is to track down all those unnecessary parameters and delete them. You can consult
the above pull request for some examples of this.


Note that there are times when the application id is actually significant, since it is used
in conjunction with the state directory to give the driver a unique place to store local state.
On the other hand, it would be sufficient to just set a unique state directory and not bother
with the app id in that case.


During review, [~chia7712] pointed out that this comment ([https://github.com/apache/kafka/blob/trunk/streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java#L138])
can be removed since it is not necessary anymore. (It's the mention of the dummy params from
the javadoc of the TopologyTestDriver)

This message was sent by Atlassian Jira

View raw message